From: Andrew Morton <akpm@linux-foundation.org>
To: wzt.wzt@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Check NULL pointer Dereference in mm/filemap.c
Date: Tue, 27 Jul 2010 16:10:49 -0700 [thread overview]
Message-ID: <20100727161049.eeac8c7c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100726082542.GA2646@localhost.localdomain>
On Mon, 26 Jul 2010 16:25:42 +0800
wzt.wzt@gmail.com wrote:
> mapping->a_ops->direct_IO() is not checked, if it's a NULL pointer,
> that will casue an oops. pagecache_write_begin/end is exported to
> other functions, so they need to check null pointer before use them.
>
The patch checks a lot more things than ->directIO!
It would be best to not add this overhead if possible. Did you
actually observe an oops? If so, please fully describe it.
prev parent reply other threads:[~2010-07-27 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 8:25 [PATCH] mm: Check NULL pointer Dereference in mm/filemap.c wzt.wzt
2010-07-27 23:10 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727161049.eeac8c7c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wzt.wzt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox