From: Andrew Morton <akpm@linux-foundation.org>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH] sysrq: don't hold the sysrq_key_table_lock during the handler
Date: Tue, 27 Jul 2010 16:36:22 -0700 [thread overview]
Message-ID: <20100727163622.a19a827b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1280138042-1576-1-git-send-email-dfeng@redhat.com>
On Mon, 26 Jul 2010 17:54:02 +0800
Xiaotian Feng <dfeng@redhat.com> wrote:
> sysrq_key_table_lock is used to protect the sysrq_key_table, make sure
> we get/replace the right operation for the sysrq. But in __handle_sysrq,
> kernel will hold this lock and disable irqs until we finished op_p->handler().
> This may cause false positive watchdog alert when we're doing "show-task-states"
> on a system with many tasks.
>
It would be better to find a suitable point in an inner loop and add an
appropriately-commented touch_nmi_watchdog().
That way the problem gets fixed for all irqs-off callers, not just one
of them.
prev parent reply other threads:[~2010-07-27 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 9:54 [RFC PATCH] sysrq: don't hold the sysrq_key_table_lock during the handler Xiaotian Feng
2010-07-26 10:51 ` Neil Horman
2010-07-26 17:41 ` Dmitry Torokhov
2010-07-26 20:34 ` Neil Horman
2010-07-27 8:15 ` Dmitry Torokhov
2010-07-27 11:57 ` Neil Horman
2010-07-27 16:38 ` Dmitry Torokhov
2010-07-27 19:24 ` Neil Horman
2010-07-27 23:36 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727163622.a19a827b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dfeng@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox