public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: Corey Minyard <cminyard@mvista.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Run a dummy command before submitting a new command
Date: Tue, 27 Jul 2010 18:21:00 +0100	[thread overview]
Message-ID: <20100727172100.GC7324@srcf.ucam.org> (raw)
In-Reply-To: <4C4F123F.3010700@mvista.com>

On Tue, Jul 27, 2010 at 12:07:11PM -0500, Corey Minyard wrote:
> I don't think this is the right way to handle the problem.  Though it's  
> not going to break anything, this change is just a hack.  We need to  
> figure out why these machine exhibit this behavior.  If it's a bug in  
> the driver, then we need to fix the driver.  If it's a bug in the HP  
> firmware, then we need to document it well as such, get HP to fix their  
> firmware, and possibly tie it into the xaction handler that's already in  
> start_next_msg.

Yeah, I agree that this isn't the optimal approach. I'm waiting to hear 
from HP if they have any idea what happened between 1.01 (which worked) 
and 1.05 (which is broken), which might give some more insight into what 
we're doing wrong.

> The only interaction with the device that this change should cause is  
> one read from the status register, since the device should be idle at  
> this point.  If that's the case, and it's not a driver bug, you can try  
> adding an xaction that calls smi_info->handlers->event(smi_info->si_sm, 
> 0).

I'll try to see what's going on.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2010-07-27 17:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 16:01 [PATCH] ipmi: Run a dummy command before submitting a new command Matthew Garrett
2010-07-27 17:07 ` Corey Minyard
2010-07-27 17:21   ` Matthew Garrett [this message]
2010-10-26 17:45     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100727172100.GC7324@srcf.ucam.org \
    --to=mjg@redhat.com \
    --cc=cminyard@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox