From: Ulf Magnusson <ulfalizer.lkml@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.35-rc6] kconfig: fix MODULES-related bug in case of no .config
Date: Tue, 27 Jul 2010 21:57:43 +0200 [thread overview]
Message-ID: <20100727195742.GA18079@ulf> (raw)
In-Reply-To: <20100727192727.GA17954@ulf>
On Tue, Jul 27, 2010 at 09:27:27PM +0200, Ulf Magnusson wrote:
> Hi,
>
> There seems to be a kconfig bug due to MODULES not always being evaluated if no
> .config is found. Take the following Kconfig as an example:
>
> config MODULES
> def_bool y
>
> config FOO
> def_tristate m
>
> With no .config, the following configuration is generated:
>
> CONFIG_MODULES=y
> CONFIG_FOO=y
>
> With an empty .config, the following:
>
> CONFIG_MODULES=y
> CONFIG_FOO=m
>
> Tristate choice statements can also exhibit the problem, due to having an
> implicit rev_dep (select) containing "m".
>
> The problem is that MODULES is never evaluted in conf_read_simple() unless
> there's a .config. The following patch fixes this.
>
> Signed-off-by: Ulf Magnusson <ulfalizer.lkml@gmail.com>
>
> diff -uNr linux.vanilla/scripts/kconfig/confdata.c linux.new/scripts/kconfig/confdata.c
> --- linux.vanilla/scripts/kconfig/confdata.c 2010-07-27 16:47:43.443006287 +0200
> +++ linux.new/scripts/kconfig/confdata.c 2010-07-27 16:50:19.795005537 +0200
> @@ -170,8 +170,10 @@
> if (in)
> goto load;
> sym_add_change_count(1);
> - if (!sym_defconfig_list)
> + if (!sym_defconfig_list) {
> + sym_calc_value(modules_sym);
> return 1;
> + }
>
> for_all_defaults(sym_defconfig_list, prop) {
> if (expr_calc_value(prop->visible.expr) == no ||
Silly error in the patch. The correct patch follows.
Signed-off-by: Ulf Magnusson <ulfalizer.lkml@gmail.com>
diff -uNr linux.vanilla/scripts/kconfig/confdata.c linux.new/scripts/kconfig/confdata.c
--- linux.vanilla/scripts/kconfig/confdata.c 2010-07-27 16:47:43.443006287 +0200
+++ linux.new/scripts/kconfig/confdata.c 2010-07-27 21:48:07.471550551 +0200
@@ -170,8 +170,11 @@
if (in)
goto load;
sym_add_change_count(1);
- if (!sym_defconfig_list)
+ if (!sym_defconfig_list) {
+ if (modules_sym)
+ sym_calc_value(modules_sym);
return 1;
+ }
for_all_defaults(sym_defconfig_list, prop) {
if (expr_calc_value(prop->visible.expr) == no ||
next prev parent reply other threads:[~2010-07-27 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 19:27 [PATCH 2.6.35-rc6] kconfig: fix MODULES-related bug in case of no .config Ulf Magnusson
2010-07-27 19:57 ` Ulf Magnusson [this message]
2010-07-28 6:23 ` Américo Wang
2010-07-29 14:54 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727195742.GA18079@ulf \
--to=ulfalizer.lkml@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox