From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753961Ab0G1TXV (ORCPT ); Wed, 28 Jul 2010 15:23:21 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:58259 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159Ab0G1TXP (ORCPT ); Wed, 28 Jul 2010 15:23:15 -0400 Date: Wed, 28 Jul 2010 12:22:23 -0700 From: Andrew Morton To: Bjorn Helgaas Cc: Yinghai Lu , Corey Minyard , Matthew Garrett , Len Brown , Myron Stowe , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: Fix ACPI detecting with regspacing Message-Id: <20100728122223.b753f586.akpm@linux-foundation.org> In-Reply-To: <201007271141.10933.bjorn.helgaas@hp.com> References: <4C4E0292.4010004@kernel.org> <201007271123.44335.bjorn.helgaas@hp.com> <4C4F173C.1010406@kernel.org> <201007271141.10933.bjorn.helgaas@hp.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jul 2010 11:41:10 -0600 Bjorn Helgaas wrote: > On Tuesday, July 27, 2010 11:28:28 am Yinghai Lu wrote: > > On 07/27/2010 10:23 AM, Bjorn Helgaas wrote: > > > On Tuesday, July 27, 2010 11:07:55 am Yinghai Lu wrote: > > >> On 07/27/2010 08:34 AM, Bjorn Helgaas wrote: > > >>> On Monday, July 26, 2010 03:48:02 pm Yinghai Lu wrote: > > >>>> > > >>>> after the commint that change ipmi_si detecting sequence from SMBIOS/ACPI to ACPI/SMBIOS, > > >>>> > > >>>> | commit 754d453185275951d39792865927ec494fa1ebd8 > > >>>> | Author: Matthew Garrett > > >>>> | Date: Wed May 26 14:43:47 2010 -0700 > > >>>> | > > >>>> | ipmi: change device discovery order > > >>>> | > > >>>> | The ipmi spec provides an ordering for si discovery. Change the driver to > > >>>> | match, with the exception of preferring smbios to SPMI as HPs (at least) > > >>>> | contain accurate information in the former but not the latter. > > >>>> > > >>>> ipmi_si can not be initialized. > > >>> > > >>> I think this patch makes sense, as long as this is not a bringup > > >>> issue that only affects pre-release firmware. If this only affects > > >>> a prototype, it would be better to change the firmware so it conforms > > >>> to the conventional _CRS usage of systems in the field. > > >>> > > >>> To that end, I'd like to know what system this is, and whether IPMI > > >>> works under Windows on this system. We know that Windows doesn't > > >>> look at SMBIOS or SPMI, so if Windows works, it must be doing something > > >>> similar to your patch. > > >> > > >> Sun Fire X4800. > > >> > > >> Yes. other OSes work and pass certification. > > > > > > Please put this information in the changelog (if that wasn't obvious). > > > > I don't want to mention other os. > > Sigh. Why is this so difficult? It wasn't for me ;) Do we have acks for 2.6.36 and a -stable backport on this patch?