From: Greg KH <greg@kroah.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Markus Grabner <grabner@icg.tugraz.at>,
gregkh@suse.de, devel@driverdev.osuosl.org
Subject: Re: [PATCH -next] staging/line6: needs to select SND_PCM
Date: Wed, 28 Jul 2010 08:19:08 -0700 [thread overview]
Message-ID: <20100728151908.GA20600@kroah.com> (raw)
In-Reply-To: <s5hhbjjvh9l.wl%tiwai@suse.de>
On Wed, Jul 28, 2010 at 03:59:50PM +0200, Takashi Iwai wrote:
> At Tue, 27 Jul 2010 12:21:19 -0700,
> Randy Dunlap wrote:
> >
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > line6 uses snd_pcm*() functions, so it should select SND_PCM.
> >
> > ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined!
> > ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined!
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > Cc: Markus Grabner <grabner@icg.tugraz.at>
> > ---
> > drivers/staging/line6/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Third patch to staging/line6/Kconfig. :(
> > Developers should know what kernel services their code needs
> > and how to configure for those needs.
>
> I think this should be applied rather to 2.6.35 tree.
I'll queue this up for stable to get it into the .35 tree eventually :)
thanks,
greg k-h
prev parent reply other threads:[~2010-07-28 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 6:07 linux-next: Tree for July 27 Stephen Rothwell
2010-07-27 7:24 ` Jaswinder Singh Rajput
2010-07-27 7:28 ` Stephen Rothwell
2010-07-27 18:35 ` Alex Elder
2010-07-28 1:24 ` Stephen Rothwell
2010-07-27 18:38 ` linux-next: Tree for July 27 (xen) Randy Dunlap
2010-07-28 13:11 ` Stefano Stabellini
2010-07-28 14:48 ` Jeremy Fitzhardinge
2010-07-28 15:06 ` Stefano Stabellini
2010-07-28 15:47 ` Randy Dunlap
2010-07-27 19:21 ` [PATCH -next] staging/line6: needs to select SND_PCM Randy Dunlap
2010-07-28 13:59 ` Takashi Iwai
2010-07-28 15:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728151908.GA20600@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=grabner@icg.tugraz.at \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox