From: Andrew Morton <akpm@linux-foundation.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
InKi Dae <inki.dae@samsung.com>
Subject: Re: [PATCH 2/2] s6e63m0: fix section mismatch
Date: Wed, 28 Jul 2010 15:31:16 -0700 [thread overview]
Message-ID: <20100728153116.634dc64b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1280286456.19065.4.camel@mola>
On Wed, 28 Jul 2010 11:07:36 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Eliminate section mismatch warning by marking s6e63m0_probe() as __devinit.
>
Please aways quote the error messages or warnings when fixing build
errors or warnings. It helps with the review quite a lot.
>
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index b27ccf9..1757379 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -732,7 +732,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
> static DEVICE_ATTR(gamma_table, 0644,
> s6e63m0_sysfs_show_gamma_table, NULL);
>
> -static int __init s6e63m0_probe(struct spi_device *spi)
> +static int __devinit s6e63m0_probe(struct spi_device *spi)
> {
> int ret = 0;
> struct s6e63m0 *lcd = NULL;
Many drivers/video/backlight/*.c drivers use __devinit for the
platform_driver.probe handler. Quite a lot use nothing (ie: .text).
Some still use __init. About half of them use __devexit_p for .remove
and half don't. It looks like it all needs a bit of loving care.
prev parent reply other threads:[~2010-07-28 22:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 3:07 [PATCH 2/2] s6e63m0: fix section mismatch Axel Lin
2010-07-28 22:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728153116.634dc64b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=inki.dae@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox