From: Christoph Hellwig <hch@infradead.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: move del_gendisk() from fs/partitions/check.c to block/genhd.c
Date: Fri, 30 Jul 2010 05:58:54 -0400 [thread overview]
Message-ID: <20100730095854.GA26949@infradead.org> (raw)
In-Reply-To: <AANLkTik-htE1mbJbnGCNwsjVJyWF24nA9dNbsRNMzuia@mail.gmail.com>
On Fri, Jul 30, 2010 at 11:56:56AM +0200, Kay Sievers wrote:
> > Sounds fine for del_gendisk, but read_dev_sector which isn't mentioned
> > here really is for partitioning.
>
> Right, the next patch moves it to /block/partition.c, because all the
> sysfs and driver core code really should not be below fs/.
>
> If you want me to re reshuffle that, let me know. I was just annoyed
> again, and after all these years I though it's time to move that stuff
> around. :)
So then please keep read_dev_sector in the file where it is right now,
and just move the whole directory from fs/partitions/ to
block/partitions. While you're at it fs/bio.c and fs/block_dev.c
really belong into block/, too. The latter could also need some split
up.
next prev parent reply other threads:[~2010-07-30 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 9:39 [PATCH] block: move del_gendisk() from fs/partitions/check.c to block/genhd.c Kay Sievers
2010-07-30 9:40 ` Christoph Hellwig
2010-07-30 9:56 ` Kay Sievers
2010-07-30 9:58 ` Christoph Hellwig [this message]
2010-07-30 10:04 ` Kay Sievers
2010-07-30 10:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730095854.GA26949@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox