From: Kristoffer Ericson <kristoffer.ericson@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static
Date: Fri, 30 Jul 2010 21:05:58 +0200 [thread overview]
Message-ID: <20100730190557.GA980@boggieman> (raw)
In-Reply-To: <1280458823.7632.3.camel@mola>
On Fri, Jul 30, 2010 at 11:00:23AM +0800, Axel Lin wrote:
> The following symbols are needlessly defined global:
> jornada_bl_init
> jornada_bl_exit
> jornada_lcd_init
> jornada_lcd_exit
>
> This patch makes the symbols static.
Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Thx.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/backlight/jornada720_bl.c | 4 ++--
> drivers/video/backlight/jornada720_lcd.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 60e1d28..a20a01a 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -146,12 +146,12 @@ static struct platform_driver jornada_bl_driver = {
> },
> };
>
> -int __init jornada_bl_init(void)
> +static int __init jornada_bl_init(void)
> {
> return platform_driver_register(&jornada_bl_driver);
> }
>
> -void __exit jornada_bl_exit(void)
> +static void __exit jornada_bl_exit(void)
> {
> platform_driver_unregister(&jornada_bl_driver);
> }
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 8fe0181..9fd7af2 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -135,12 +135,12 @@ static struct platform_driver jornada_lcd_driver = {
> },
> };
>
> -int __init jornada_lcd_init(void)
> +static int __init jornada_lcd_init(void)
> {
> return platform_driver_register(&jornada_lcd_driver);
> }
>
> -void __exit jornada_lcd_exit(void)
> +static void __exit jornada_lcd_exit(void)
> {
> platform_driver_unregister(&jornada_lcd_driver);
> }
> --
> 1.5.4.3
>
>
prev parent reply other threads:[~2010-07-30 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 3:00 [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static Axel Lin
2010-07-30 19:05 ` Kristoffer Ericson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730190557.GA980@boggieman \
--to=kristoffer.ericson@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox