* [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static
@ 2010-07-30 3:00 Axel Lin
2010-07-30 19:05 ` Kristoffer Ericson
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2010-07-30 3:00 UTC (permalink / raw)
To: linux-kernel; +Cc: Richard Purdie, Kristoffer Ericson, Andrew Morton
The following symbols are needlessly defined global:
jornada_bl_init
jornada_bl_exit
jornada_lcd_init
jornada_lcd_exit
This patch makes the symbols static.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/video/backlight/jornada720_bl.c | 4 ++--
drivers/video/backlight/jornada720_lcd.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
index 60e1d28..a20a01a 100644
--- a/drivers/video/backlight/jornada720_bl.c
+++ b/drivers/video/backlight/jornada720_bl.c
@@ -146,12 +146,12 @@ static struct platform_driver jornada_bl_driver = {
},
};
-int __init jornada_bl_init(void)
+static int __init jornada_bl_init(void)
{
return platform_driver_register(&jornada_bl_driver);
}
-void __exit jornada_bl_exit(void)
+static void __exit jornada_bl_exit(void)
{
platform_driver_unregister(&jornada_bl_driver);
}
diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
index 8fe0181..9fd7af2 100644
--- a/drivers/video/backlight/jornada720_lcd.c
+++ b/drivers/video/backlight/jornada720_lcd.c
@@ -135,12 +135,12 @@ static struct platform_driver jornada_lcd_driver = {
},
};
-int __init jornada_lcd_init(void)
+static int __init jornada_lcd_init(void)
{
return platform_driver_register(&jornada_lcd_driver);
}
-void __exit jornada_lcd_exit(void)
+static void __exit jornada_lcd_exit(void)
{
platform_driver_unregister(&jornada_lcd_driver);
}
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static
2010-07-30 3:00 [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static Axel Lin
@ 2010-07-30 19:05 ` Kristoffer Ericson
0 siblings, 0 replies; 2+ messages in thread
From: Kristoffer Ericson @ 2010-07-30 19:05 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Richard Purdie, Andrew Morton
On Fri, Jul 30, 2010 at 11:00:23AM +0800, Axel Lin wrote:
> The following symbols are needlessly defined global:
> jornada_bl_init
> jornada_bl_exit
> jornada_lcd_init
> jornada_lcd_exit
>
> This patch makes the symbols static.
Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Thx.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/backlight/jornada720_bl.c | 4 ++--
> drivers/video/backlight/jornada720_lcd.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
> index 60e1d28..a20a01a 100644
> --- a/drivers/video/backlight/jornada720_bl.c
> +++ b/drivers/video/backlight/jornada720_bl.c
> @@ -146,12 +146,12 @@ static struct platform_driver jornada_bl_driver = {
> },
> };
>
> -int __init jornada_bl_init(void)
> +static int __init jornada_bl_init(void)
> {
> return platform_driver_register(&jornada_bl_driver);
> }
>
> -void __exit jornada_bl_exit(void)
> +static void __exit jornada_bl_exit(void)
> {
> platform_driver_unregister(&jornada_bl_driver);
> }
> diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c
> index 8fe0181..9fd7af2 100644
> --- a/drivers/video/backlight/jornada720_lcd.c
> +++ b/drivers/video/backlight/jornada720_lcd.c
> @@ -135,12 +135,12 @@ static struct platform_driver jornada_lcd_driver = {
> },
> };
>
> -int __init jornada_lcd_init(void)
> +static int __init jornada_lcd_init(void)
> {
> return platform_driver_register(&jornada_lcd_driver);
> }
>
> -void __exit jornada_lcd_exit(void)
> +static void __exit jornada_lcd_exit(void)
> {
> platform_driver_unregister(&jornada_lcd_driver);
> }
> --
> 1.5.4.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-30 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-30 3:00 [PATCH] jornada720_bl/jornada720_lcd: make needlessly global symbols static Axel Lin
2010-07-30 19:05 ` Kristoffer Ericson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox