From: Greg KH <greg@kroah.com>
To: David Brownell <david-b@pacbell.net>
Cc: "Michał Nazarewicz" <m.nazarewicz@samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dries Van Puymbroeck" <Dries.VanPuymbroeck@dekimo.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>
Subject: Re: [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets
Date: Fri, 30 Jul 2010 14:21:31 -0700 [thread overview]
Message-ID: <20100730212131.GA8787@kroah.com> (raw)
In-Reply-To: <355626.7330.qm@web180313.mail.gq1.yahoo.com>
On Fri, Jul 30, 2010 at 11:57:35AM -0700, David Brownell wrote:
>
> >
> > We shouldn't be using _any_ netchip
> > ids anymore now that we
> > have our own vendor id assigned to us.
>
> That's too extreme; the original handful of
> NetChip IDs were (and are!!) correctly assigned,
> and there's no reason to change them. In fact,
> there's a lot of reason to continue using them
> while config files and drivers expect to see
> those specific IDs (as is reasonable). That's
> to avoid breaking working configs...
True, I was thinking that for the class-type devices, we could use the
linux foundation vid, as changing them shouldn't matter right?
Or does Windows really care about the vid/pid for a class device
somehow?
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-30 21:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 12:13 [PATCHv5 1/3] USB: gadget: composite: Better string override handling Michal Nazarewicz
2010-07-28 12:13 ` [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets Michal Nazarewicz
2010-07-28 12:13 ` [PATCHv5 3/3] USB: gadget: storage_common: fixed warning building mass storage function Michal Nazarewicz
2010-07-28 12:25 ` Andy Shevchenko
2010-07-28 13:02 ` Michał Nazarewicz
2010-07-28 13:42 ` Andy Shevchenko
2010-07-28 14:02 ` Michał Nazarewicz
2010-07-29 22:21 ` [PATCHv5 2/3] USB: gadget: Use new composite features in some gadgets David Brownell
2010-07-30 16:48 ` Michał Nazarewicz
2010-07-30 16:54 ` Greg KH
2010-07-30 18:57 ` David Brownell
2010-07-30 21:21 ` Greg KH [this message]
2010-07-30 22:01 ` David Brownell
2010-07-30 22:16 ` Greg KH
2010-07-30 23:58 ` Xiaofan Chen
2010-08-02 17:14 ` Michał Nazarewicz
2010-08-02 22:52 ` Greg KH
2010-08-04 9:21 ` Michal Nazarewicz
2010-08-01 19:05 ` [PATCHv5 1/3] USB: gadget: composite: Better string override handling David Brownell
2010-08-02 9:48 ` Michał Nazarewicz
2010-08-02 11:26 ` David Brownell
2010-08-02 12:47 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730212131.GA8787@kroah.com \
--to=greg@kroah.com \
--cc=Dries.VanPuymbroeck@dekimo.com \
--cc=david-b@pacbell.net \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox