From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Markus Metzger <markus.t.metzger@intel.com>,
Robert Richter <robert.richter@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] BTS based perf user callchains
Date: Mon, 2 Aug 2010 20:41:51 +0200 [thread overview]
Message-ID: <20100802184149.GB8962@nowhere> (raw)
In-Reply-To: <1280774332.1923.245.camel@laptop>
On Mon, Aug 02, 2010 at 08:38:52PM +0200, Peter Zijlstra wrote:
> On Mon, 2010-08-02 at 20:35 +0200, Frederic Weisbecker wrote:
> > I'm not even sure that will work. Also, while looking at the BTS implementation
> > in perf, I see we have one BTS buffer per cpu. But that doesn't look right as
> > the code flow is not linear per cpu but per task. Hence I suspect we need
> > one BTS buffer per task. But may be someone tried that and encountered a
> > problem?
>
> IIRC we flush the buffer when we deschedule the counter.
Ok. So the buffer is cut on schedule time. It might be nice
to maintain the buffer progress across scheduling.
That requires one buffer per task though. That could be worth.
next prev parent reply other threads:[~2010-08-02 18:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 18:35 [RFC] BTS based perf user callchains Frederic Weisbecker
2010-08-02 18:38 ` Peter Zijlstra
2010-08-02 18:41 ` Frederic Weisbecker [this message]
2010-08-02 19:47 ` Peter Zijlstra
2010-08-03 6:53 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802184149.GB8962@nowhere \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox