From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755610Ab0HCJMA (ORCPT ); Tue, 3 Aug 2010 05:12:00 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49684 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640Ab0HCJL6 (ORCPT ); Tue, 3 Aug 2010 05:11:58 -0400 Date: Tue, 3 Aug 2010 02:11:10 -0700 From: Andrew Morton To: David Miller Cc: andyc.bluearc@gmail.com, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, eric.dumazet@gmail.com, William.Allen.Simpson@gmail.com, gilad@codefidence.com, ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH] [Bug 16494] NFS client over TCP hangs due to packet loss Message-Id: <20100803021110.f0b3877b.akpm@linux-foundation.org> In-Reply-To: <20100803.012144.267950450.davem@davemloft.net> References: <4c57cfe8.887b0e0a.2f79.4772@mx.google.com> <20100803.012144.267950450.davem@davemloft.net> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (cc linux-nfs) On Tue, 03 Aug 2010 01:21:44 -0700 (PDT) David Miller wrote: > From: "Andy Chittenden" > Date: Tue, 3 Aug 2010 09:14:31 +0100 > > > I don't know whether this patch is the correct fix or not but it enables the > > NFS client to recover. > > > > Kernel version: 2.6.34.1 and 2.6.32. > > > > Fixes . It clears down > > any previous shutdown attempts so that reconnects on a socket that's been > > shutdown leave the socket in a usable state (otherwise tcp_sendmsg() returns > > -EPIPE). > > If the SunRPC code wants to close a TCP socket then use it again, > it should disconnect by doing a connect() with sa_family == AF_UNSPEC