From: Arnd Bergmann <arnd@arndb.de>
To: Edgardo Hames <ehames@gmail.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h
Date: Tue, 3 Aug 2010 15:24:04 +0200 [thread overview]
Message-ID: <201008031524.04730.arnd@arndb.de> (raw)
In-Reply-To: <1280593762-23120-1-git-send-email-ehames@gmail.com>
On Saturday 31 July 2010, Edgardo Hames wrote:
>
> -typedef struct p80211ioctl_req {
> +struct p80211ioctl_req {
> char name[WLAN_DEVNAMELEN_MAX];
> caddr_t data;
> u32 magic;
> u16 len;
> u32 result;
> -} __attribute__ ((packed)) p80211ioctl_req_t;
> +} __attribute__ ((packed));
BTW, this data structure is broken and needs fixing.
Putting a pointer in there means that it's incompatible
between 32 and 64 bit user space, among other problems.
The TODO list for this driver already contains "move to
use the in-kernel wireless stack", which should consequently
imply getting rid of this p80211knetdev_do_ioctl function, but
it may be useful to list that as a separate item.
Arnd
prev parent reply other threads:[~2010-08-03 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 16:29 [PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h Edgardo Hames
2010-08-03 13:24 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008031524.04730.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ehames@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox