[PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h

[PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h

[Edgardo Hames]

This patches removes the only typedef in p80211ioctl.h

Signed-off-by: Edgardo Hames <ehames@gmail.com>
---
 drivers/staging/wlan-ng/p80211ioctl.h  |    4 ++--
 drivers/staging/wlan-ng/p80211netdev.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211ioctl.h b/drivers/staging/wlan-ng/p80211ioctl.h
index 64ca7f9..0d47765 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -78,12 +78,12 @@
 /*  argument to the ioctl system call when issuing a request to */
 /*  the p80211 module. */
 
-typedef struct p80211ioctl_req {
+struct p80211ioctl_req {
 	char name[WLAN_DEVNAMELEN_MAX];
 	caddr_t data;
 	u32 magic;
 	u16 len;
 	u32 result;
-} __attribute__ ((packed)) p80211ioctl_req_t;
+} __attribute__ ((packed));
 
 #endif /* _P80211IOCTL_H */
diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c
index 5b68af0..a57ac52 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -560,7 +560,7 @@ static int p80211netdev_ethtool(wlandevice_t *wlandev, void __user *useraddr)
 static int p80211knetdev_do_ioctl(netdevice_t *dev, struct ifreq *ifr, int cmd)
 {
 	int result = 0;
-	p80211ioctl_req_t *req = (p80211ioctl_req_t *) ifr;
+	struct p80211ioctl_req *req = (struct p80211ioctl_req *) ifr;
 	wlandevice_t *wlandev = dev->ml_priv;
 	u8 *msgbuf;
 
-- 
1.7.0.4

Re: [PATCH] Staging: wlan-ng: remove typedef in p80211ioctl.h

[Arnd Bergmann]

On Saturday 31 July 2010, Edgardo Hames wrote:
> 
> -typedef struct p80211ioctl_req {
> +struct p80211ioctl_req {
>         char name[WLAN_DEVNAMELEN_MAX];
>         caddr_t data;
>         u32 magic;
>         u16 len;
>         u32 result;
> -} __attribute__ ((packed)) p80211ioctl_req_t;
> +} __attribute__ ((packed));

BTW, this data structure is broken and needs fixing.
Putting a pointer in there means that it's incompatible
between 32 and 64 bit user space, among other problems.

The TODO list for this driver already contains "move to
use the in-kernel wireless stack", which should consequently
imply getting rid of this p80211knetdev_do_ioctl function, but
it may be useful to list that as a separate item.

	Arnd