From: Pavel Machek <pavel@ucw.cz>
To: Patrick Pannuto <ppannuto@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, apw@canonical.com, corbet@lwn.net
Subject: Re: [PATCH v2 0/4] timer: Added usleep[_range] timer
Date: Tue, 3 Aug 2010 21:12:38 +0200 [thread overview]
Message-ID: <20100803191049.GC1522@ucw.cz> (raw)
In-Reply-To: <1280345587-19725-1-git-send-email-ppannuto@codeaurora.org>
On Wed 2010-07-28 12:33:03, Patrick Pannuto wrote:
> After writing both documentation and a checkpatch rule explaining
> why the usleep API should never be used, it occurred to me that
> perhaps such an API should never be added :) - at least not in its
> previous form.
>
> This iteration is similar, with the notable difference that now
> usleep has a "built-in slack" of 200%. This is analogous to msleep,
> which has a built-in slack of 0.4% (since it relies on legacy timers,
> which have a built-in slack of 0.4%). 200% slack is significantly
> greater than 0.4%, but the scale of usleep is also significantly
> different than that of msleep, and I believe 200% to be a sane
> default.
So, I do msleep(1 second) and it will delay for 3 seconds? Thats
excessive, and will be annoying/plain to see with just eyes. Better
select reasonable default (1%?) and let people who care switch to
msleep_range...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2010-08-04 7:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 19:33 [PATCH v2 0/4] timer: Added usleep[_range] timer Patrick Pannuto
2010-07-28 19:33 ` [PATCH 1/4] " Patrick Pannuto
2010-07-28 20:23 ` Andrew Morton
2010-07-28 20:47 ` Patrick Pannuto
2010-07-28 20:58 ` Andrew Morton
2010-07-28 21:04 ` Arjan van de Ven
2010-07-28 21:11 ` Patrick Pannuto
2010-07-28 21:22 ` Andrew Morton
2010-07-28 21:25 ` Arjan van de Ven
2010-07-28 21:05 ` Patrick Pannuto
2010-07-28 21:23 ` Andrew Morton
2010-07-28 21:26 ` Arjan van de Ven
2010-07-28 19:33 ` [PATCH 2/4] Documentation: Add timers/timers-howto.txt Patrick Pannuto
2010-07-28 19:33 ` [PATCH 3/4] Checkpatch: prefer usleep over udelay Patrick Pannuto
2010-07-28 20:24 ` Andrew Morton
2010-07-28 19:33 ` [PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's Patrick Pannuto
2010-07-28 20:24 ` Andrew Morton
2010-07-28 20:48 ` Patrick Pannuto
2010-08-03 19:12 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803191049.GC1522@ucw.cz \
--to=pavel@ucw.cz \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ppannuto@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox