Re: [PATCH 2.6.37? ] drivers/input: Use pr_

Dmitry Torokhov
2010-08-04T04:33:05Z

Hi Joe,

On Tue, Aug 03, 2010 at 11:40:50AM -0700, Joe Perches wrote:
> Remove prefixes from printks and convert to pr_fmt/pr_<level>.
>
> Always make output prefix match module name.
> There are some existing uses that do not. For instance:
> spaceorb used "input: " once, probably a copy/paste error,
> newtonkbd as well. Synaptics used "serio: ", etc.
>
> A few miscellaneous typos corrected.
> Converted a few uses of usb macros err to pr_err.
>
> Compiled x86 only, some files not compile tested
>

Thanks for doing this, however instead of using pr_xxx() I'd like
drivers that are integrated in driver model (serio, usb, gameport, etc,
i.e. when we have 'struct device' available, exept for psmouse) to use
drv_xxx() instead.

>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 8c32440..e02c2a7 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -23,6 +23,8 @@
> * Trademarks are the property of their respective owners.
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +

That would make synaptics messages to come as "psmouse", right? I think
we shoudl use

#define pr_fmt(fmt) "synaptics: " fmt

here and in the rest of specialized PS/2 protocol handlers.

Thanks.

--
Dmitry