From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Gordeev <lasaine@lvk.cs.msu.su>
Cc: linux-kernel@vger.kernel.org,
"Nikita V\. Youshchenko" <yoush@cs.msu.su>,
linuxpps@ml.enneenne.com,
Rodolfo Giometti <giometti@enneenne.com>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCHv3 16/16] pps: add parallel port PPS signal generator
Date: Wed, 4 Aug 2010 16:38:04 -0700 [thread overview]
Message-ID: <20100804163804.fce2ffd6.akpm@linux-foundation.org> (raw)
In-Reply-To: <6015d3803449935de8f1425efdfae4736d775047.1280952801.git.lasaine@lvk.cs.msu.su>
On Thu, 5 Aug 2010 01:06:53 +0400
Alexander Gordeev <lasaine@lvk.cs.msu.su> wrote:
> Add PPS signal generator which utilizes STROBE pin of a parallel port to
> send PPS signals. It uses parport abstraction layer and hrtimers to
> precisely control the signal.
>
> ..
>
> +static unsigned int send_delay = 30000;
> +MODULE_PARM_DESC(delay,
> + "Delay between setting and dropping the signal (ns)");
> +module_param_named(delay, send_delay, uint, 0);
This code doesn't look easy to configure and use. For example, if some
random person tries to get it going, how does he even know that this
module parameter exists, let alone how to use it?
Please review Documentation/pps/pps.txt and check that it accurately
and completely describes how to use the pps code after your changes,
thanks.
prev parent reply other threads:[~2010-08-04 23:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 21:06 [PATCHv3 00/16] pps: several fixes and improvements Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 01/16] pps: trivial fixes Alexander Gordeev
2010-08-05 8:57 ` Rodolfo Giometti
2010-08-04 21:06 ` [PATCHv3 02/16] pps: declare variables where they are used in switch Alexander Gordeev
2010-08-05 9:05 ` Rodolfo Giometti
2010-08-04 21:06 ` [PATCHv3 03/16] pps: fix race in PPS_FETCH handler Alexander Gordeev
2010-08-05 5:19 ` Vitezslav Samel
2010-08-05 10:19 ` Alexander Gordeev
2010-08-05 11:07 ` Vitezslav Samel
2010-08-05 14:31 ` Alexander Gordeev
2010-08-05 9:15 ` Rodolfo Giometti
2010-08-04 21:06 ` [PATCHv3 04/16] pps: unify timestamp gathering Alexander Gordeev
2010-08-05 9:17 ` Rodolfo Giometti
2010-08-04 21:06 ` [PATCHv3 05/16] pps: access pps device by direct pointer Alexander Gordeev
2010-08-05 9:32 ` Rodolfo Giometti
2010-08-05 11:42 ` Alexander Gordeev
2010-08-05 12:31 ` Rodolfo Giometti
2010-08-09 7:53 ` Alexander Gordeev
2010-08-09 12:47 ` Rodolfo Giometti
2010-08-04 21:06 ` [PATCHv3 06/16] pps: convert printk/pr_* to dev_* Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 07/16] pps: move idr stuff to pps.c Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 08/16] pps: add async PPS event handler Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 09/16] pps: don't disable interrupts when using spin locks Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 10/16] pps: use BUG_ON for kernel API safety checks Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 11/16] pps: simplify conditions a bit Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 12/16] ntp: add hardpps implementation Alexander Gordeev
2010-08-04 22:49 ` john stultz
2010-08-05 12:00 ` Alexander Gordeev
2010-08-04 23:26 ` Andrew Morton
2010-08-04 23:39 ` David Daney
2010-08-04 23:49 ` Andrew Morton
2010-08-04 21:06 ` [PATCHv3 13/16] pps: capture MONOTONIC_RAW timestamps as well Alexander Gordeev
2010-08-04 23:03 ` john stultz
2010-08-05 12:16 ` Alexander Gordeev
2010-08-04 23:29 ` Andrew Morton
2010-08-05 12:29 ` Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 14/16] pps: add kernel consumer support Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 15/16] pps: add parallel port PPS client Alexander Gordeev
2010-08-04 23:34 ` Andrew Morton
2010-08-05 12:48 ` Alexander Gordeev
2010-08-04 21:06 ` [PATCHv3 16/16] pps: add parallel port PPS signal generator Alexander Gordeev
2010-08-04 23:38 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804163804.fce2ffd6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=giometti@enneenne.com \
--cc=johnstul@us.ibm.com \
--cc=lasaine@lvk.cs.msu.su \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxpps@ml.enneenne.com \
--cc=yoush@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).