public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"'devel@driverdev.osuosl.org'" <devel@driverdev.osuosl.org>,
	"'virtualization@lists.osdl.org'" <virtualization@lists.osdl.org>,
	Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 2/6] staging: hv: Fixed lockup problem with bounce_buffer scatter list
Date: Wed, 4 Aug 2010 10:05:03 -0700	[thread overview]
Message-ID: <20100804170503.GB28217@suse.de> (raw)
In-Reply-To: <8AFC7968D54FB448A30D8F38F259C56223FE7AF6@TK5EX14MBXC114.redmond.corp.microsoft.com>

On Wed, Aug 04, 2010 at 04:32:17AM +0000, Hank Janssen wrote:
> And then Greg spoke:
> >> On Tue, Aug 03, 2010 at 05:31:53PM +0000, Hank Janssen wrote:
> >> From: Hank Janssen <hjanssen@microsoft.com>
> > >
> > >Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads.
> >
> >Same questions for you as patch 1/6.
> >
> >Also, please wrap your changelog comments at 72 columns.
>  
> Under heavy loads with many clients we this problem appears, it causes a kernel 
> Panic.

Great, please provide this info.

> Yes, this should be backported to all stable kernel releases that have the 
> Hyper-V drivers In them.  

Again, add a cc: stable <stable@kernel.org> to the patch please.

> >> Signed-off-by:Hank Janssen <hjanssen@microsoft.com> 
> >> Signed-off-by:Haiyang Zhang <haiyangz@microsoft.com>
> >
> >What's with the trailing space?
> 
> Same problem as wrapping my comments at 72  chars, I just upgraded to the latest
> Evil outlook 2010, and my settings in office 2007 did not transfer so I have to 
> Set up all the stuff that fixes these problems :(
> 
> Do you want me to re-submit with correct wrapping?

Yes.  But you also have trailing spaces in some of these patches as
well, which need to be addressed.

thanks,

greg k-h

      reply	other threads:[~2010-08-04 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 17:31 [PATCH 2/6] staging: hv: Fixed lockup problem with bounce_buffer scatter list Hank Janssen
2010-08-03 17:38 ` Greg KH
2010-08-04  4:32   ` Hank Janssen
2010-08-04 17:05     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100804170503.GB28217@suse.de \
    --to=gregkh@suse.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=haiyangz@microsoft.com \
    --cc=hjanssen@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox