From: Robert Richter <robert.richter@amd.com>
To: Josh Hunt <johunt@akamai.com>, Ingo Molnar <mingo@elte.hu>
Cc: "oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"juhlenko@akamai.com" <juhlenko@akamai.com>
Subject: Re: [PATCH] oprofile: add support for Intel processor model 30
Date: Thu, 5 Aug 2010 12:32:06 +0200 [thread overview]
Message-ID: <20100805103206.GM26154@erda.amd.com> (raw)
In-Reply-To: <1280968025-16969-1-git-send-email-johunt@akamai.com>
On 04.08.10 20:27:05, Josh Hunt wrote:
> Newer Intel processors identifying themselves as model 30 are not recognized by
> oprofile.
> Tested using oprofile 0.9.6.
>
> Signed-off-by: Josh Hunt <johunt@akamai.com>
Applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git core
(I converted the model number to hex.)
Thanks Josh.
Ingo,
please (ff-only) pull this again for tip/perf/core. You already send
the pull request for Linus, but I think this patch will make it for
v2.6.36 too?
Thanks.
-Robert
> ---
> arch/x86/oprofile/nmi_int.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
> index b28d2f1..6f95251 100644
> --- a/arch/x86/oprofile/nmi_int.c
> +++ b/arch/x86/oprofile/nmi_int.c
> @@ -657,6 +657,7 @@ static int __init ppro_init(char **cpu_type)
> break;
> case 0x2e:
> case 26:
> + case 30:
> spec = &op_arch_perfmon_spec;
> *cpu_type = "i386/core_i7";
> break;
> --
> 1.7.0.4
>
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2010-08-05 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 0:27 [PATCH] oprofile: add support for Intel processor model 30 Josh Hunt
2010-08-05 6:59 ` Andi Kleen
2010-08-05 10:32 ` Robert Richter [this message]
2010-08-05 12:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805103206.GM26154@erda.amd.com \
--to=robert.richter@amd.com \
--cc=andi@firstfloor.org \
--cc=johunt@akamai.com \
--cc=juhlenko@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox