From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/2] lp3971: remove unnecessary ret value checking in lp3971_i2c_write()
Date: Thu, 5 Aug 2010 13:11:46 +0100 [thread overview]
Message-ID: <20100805121145.GD13146@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1280979638.1238.2.camel@mola>
On Thu, Aug 05, 2010 at 11:40:38AM +0800, Axel Lin wrote:
> i2c_smbus_write_byte_data() returns zero or negative value,
> therefore no need to check if ret is greater than zero or not.
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but can I once more renew my request that you make some effort to
provide subject lines for your patches which are consistent with the
standard used for the area of the kernel you're submitting to?
next prev parent reply other threads:[~2010-08-05 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 3:40 [PATCH 1/2] lp3971: remove unnecessary ret value checking in lp3971_i2c_write() Axel Lin
2010-08-05 12:11 ` Mark Brown [this message]
2010-08-05 14:22 ` Axel Lin
2010-08-05 14:43 ` Mark Brown
2010-08-05 23:56 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805121145.GD13146@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox