From: Greg KH <gregkh@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>,
Philippe Langlais <philippe.langlais@stericsson.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
Ludovic BARRE <ludovic.barre@stericsson.com>,
Vincent GUITTOT <vincent.guittot@stericsson.com>
Subject: Re: [PATCH] U6715 16550A serial driver support
Date: Thu, 5 Aug 2010 16:04:35 -0700 [thread overview]
Message-ID: <20100805230435.GA30372@suse.de> (raw)
In-Reply-To: <20100805002206.758777aa.akpm@linux-foundation.org>
On Thu, Aug 05, 2010 at 12:22:06AM -0700, Andrew Morton wrote:
> On Thu, 5 Aug 2010 09:14:40 +0200 Philippe Langlais <philippe.langlais@stericsson.com> wrote:
>
> >
> > >>
> > > The patch adds these .set_termios hooks but doesn't actually use them
> > > for anything.
> > >
> > > The changelog doesn't tell us _why_ this was done (it should) and
> > > lacking any code to look at it's all a bit mysterious.
> > >
> > >
> > This feature is used in our U6715 8250 platform serial driver, to avoid
> > hack in 8250.c set_termios (Alan Cox requirement).
> > In this driver the input uart clock frequency depends on baud rate and
> > is computed in our set_termios override function.
> > The U6715 paltform serial patch has been submitted on linux-arm mailing
> > list,
> > and is ready to enter Russell King Linux tree.
>
> Oh.
>
> > More things to do ?
>
> Update the changelog to include this rather important information.
>
> As the patches are dependent, treat them as a single series. Russell
> can merge them both with Greg's ack or Greg can merge them both with
> Russell's ack.
I've dropped the patch from my tree, so send it through Russell's, with
the proper changelog change and:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-05 23:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 8:58 [PATCH] U6715 16550A serial driver support Philippe Langlais
2010-08-04 19:52 ` Andrew Morton
2010-08-05 7:14 ` Philippe Langlais
2010-08-05 7:22 ` Andrew Morton
2010-08-05 8:51 ` Philippe Langlais
2010-08-05 9:00 ` Andrew Morton
2010-08-05 23:04 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-29 15:13 Philippe Langlais
2010-07-29 15:31 ` Alan Cox
2010-07-29 13:32 New U6715 8250 serial patch Philippe Langlais
2010-07-29 13:32 ` [PATCH] U6715 16550A serial driver support Philippe Langlais
2010-07-29 13:53 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805230435.GA30372@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.barre@stericsson.com \
--cc=philippe.langlais@stericsson.com \
--cc=vincent.guittot@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox