From: Olivier Galibert <galibert@pobox.com>
To: Kyle Moffett <kyle@moffetthome.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Herbert Xu <herbert@gondor.hengli.com.au>,
David Howells <dhowells@redhat.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem
Date: Fri, 6 Aug 2010 10:06:42 +0200 [thread overview]
Message-ID: <20100806080642.GA4642@dspnet.fr> (raw)
In-Reply-To: <AANLkTinVO0prEfkuOUFWA12q8HwrXS6do_hjw1EqygZu@mail.gmail.com>
On Fri, Aug 06, 2010 at 12:50:04AM -0400, Kyle Moffett wrote:
> You should also realize that crypto drivers are very much *NOT* in the
> same situation as most other drivers. Without this test, adding a new
> crypto hardware driver to the kernel is a completely unsafe operation,
> because it could completely break users setups. You have previously
> said you're fine accepting new drivers even after the initial merge
> window because they can't break anything, but in crypto that's not
> true.
Maybe Linus would be happier if the self-tests were limited (by
default) to the hardware accelerators? Having a software backup and
the risk of data loss indeed makes things different.
Of course in practice without the tests your boot would probably just
have failed. Badly-decrypted root partitions tend to be noticed as
such long before trying to write to them. Then you would have bitched
on the list and the driver would have been fixed or removed faster
than having to wait for you (or other people with the hardware issue)
to notice the spew in dmesg.
OG.
next prev parent reply other threads:[~2010-08-06 8:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 1:01 Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem David Howells
2010-08-06 1:17 ` Herbert Xu
2010-08-06 1:40 ` Herbert Xu
2010-08-06 2:01 ` Linus Torvalds
2010-08-06 2:23 ` David Howells
2010-08-06 2:27 ` Linus Torvalds
2010-08-06 2:35 ` Herbert Xu
2010-08-06 4:20 ` Linus Torvalds
2010-08-06 4:50 ` Kyle Moffett
2010-08-06 8:06 ` Olivier Galibert [this message]
2010-08-06 8:39 ` Herbert Xu
2010-08-06 11:13 ` Evgeniy Polyakov
2010-08-06 15:22 ` Linus Torvalds
2010-08-06 2:27 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806080642.GA4642@dspnet.fr \
--to=galibert@pobox.com \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=herbert@gondor.hengli.com.au \
--cc=kyle@moffetthome.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox