From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 05/10] perf hists: Fixup addr snprintf width on 32 bit arches
Date: Fri, 6 Aug 2010 11:29:45 -0300 [thread overview]
Message-ID: <20100806142945.GC17509@ghostprotocols.net> (raw)
In-Reply-To: <1281059887.19943.23.camel@Joe-Laptop.home>
Em Thu, Aug 05, 2010 at 06:58:07PM -0700, Joe Perches escreveu:
> On Thu, 2010-08-05 at 22:46 -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > By using BITS_PER_LONG/4 as the width specifier.
> []
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index 1c61a4f..b62a553 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> []
> > - ret += repsep_snprintf(bf, size, "%#018llx %c ", self->ip, o);
> > + ret += repsep_snprintf(bf, size, "%*Lx %c ",
> > + BITS_PER_LONG / 4, self->ip, o);
> []
> > - ret += repsep_snprintf(bf + ret, size - ret, "%#016llx", self->ip);
> > + ret += repsep_snprintf(bf + ret, size - ret, "%*Lx",
> > + BITS_PER_LONG / 4, self->ip);
>
> This drops leading 0's.
Is this a problem? This removes clutter from the output, right?
- Arnaldo
next prev parent reply other threads:[~2010-08-06 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 1:46 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 01/10] perf symbols: Store the symbol binding Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 02/10] perf ui: Add a map browser Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 03/10] perf ui: Shorten ui_browser->refresh_entries to refresh Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 04/10] perf hists: Handle verbose in hists__sort_list_width Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 05/10] perf hists: Fixup addr snprintf width on 32 bit arches Arnaldo Carvalho de Melo
2010-08-06 1:58 ` Joe Perches
2010-08-06 14:29 ` Arnaldo Carvalho de Melo [this message]
2010-08-06 15:35 ` Joe Perches
2010-08-06 15:40 ` Joe Perches
2010-08-06 1:46 ` [PATCH 06/10] perf ui: Add search by name/addr to the map__browser Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 07/10] perf probe: Remove duplicated #include Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 08/10] perf trace: Clean up #includes Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 09/10] perf timechart: Adjust confusing if indentation Arnaldo Carvalho de Melo
2010-08-06 1:46 ` [PATCH 10/10] perf report: Speed up exit path Arnaldo Carvalho de Melo
2010-08-06 7:00 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806142945.GC17509@ghostprotocols.net \
--to=acme@infradead.org \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).