From: Greg KH <gregkh@suse.de>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] serport: place serport serio device correctly in the device tree
Date: Fri, 6 Aug 2010 09:57:58 -0700 [thread overview]
Message-ID: <20100806165758.GA3364@suse.de> (raw)
In-Reply-To: <1281112169-27086-2-git-send-email-dbaryshkov@gmail.com>
On Fri, Aug 06, 2010 at 08:29:29PM +0400, Dmitry Eremin-Solenikov wrote:
> Make serport serio device to be a child of corresponding tty device
> instead of just hanging at /sys/devices/serioX.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> drivers/input/serio/serport.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c
> index 6d34511..ee0ff0c 100644
> --- a/drivers/input/serio/serport.c
> +++ b/drivers/input/serio/serport.c
> @@ -165,6 +165,7 @@ static ssize_t serport_ldisc_read(struct tty_struct * tty, struct file * file, u
> serio->open = serport_serio_open;
> serio->close = serport_serio_close;
> serio->port_data = serport;
> + serio->dev.parent = tty_get_device(tty);
You just grabbed a reference to this device, do you ever need to free it
up?
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-06 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 16:29 [PATCH 1/2] tty_io: add an API to get device corresponding to tty_struct Dmitry Eremin-Solenikov
2010-08-06 16:29 ` [PATCH 2/2] serport: place serport serio device correctly in the device tree Dmitry Eremin-Solenikov
2010-08-06 16:57 ` Greg KH [this message]
2010-08-07 9:55 ` Dmitry Eremin-Solenikov
2010-08-06 16:58 ` [PATCH 1/2] tty_io: add an API to get device corresponding to tty_struct Greg KH
2010-08-07 9:55 ` Dmitry Eremin-Solenikov
2010-08-07 11:33 ` Alan Cox
2010-08-08 0:38 ` Dmitry Eremin-Solenikov
2010-08-08 12:56 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2010-08-09 14:22 [PATCH 1/2] tty: add tty_struct->dev pointer to corresponding device instance Dmitry Eremin-Solenikov
2010-08-09 14:22 ` [PATCH 2/2] serport: place serport serio device correctly in the device tree Dmitry Eremin-Solenikov
2010-08-11 3:27 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806165758.GA3364@suse.de \
--to=gregkh@suse.de \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox