Re: PATCH: West Bridge Driver Kernel Support linux-2.6.35

Re: PATCH: West Bridge Driver Kernel Support linux-2.6.35

[Greg KH]

On Fri, Aug 06, 2010 at 11:38:22AM -0700, David Cross wrote:
> Re-Re-sending in plain text.
> 
> This is a driver for the Cypress West Bridge companion chip. Its function is
> analogous to the North/South Bridges of PC environments applied to embedded
> devices, in that it expands I/O and storage capabilities of an embedded
> processor.

Odd, your patch contains a lot of stuff it shouldn't, here's the
diffstat to show what I mean:

 Documentation/dontdiff                             |11723 ++++++++++++++++++++-
 arch/arm/mach-omap2/gpmc.c                         |    3 
 block/modules.builtin                              |    2 
 crypto/modules.builtin                             |   16 
 drivers/block/modules.builtin                      |    2 
 drivers/char/hw_random/modules.builtin             |    1 
 drivers/char/modules.builtin                       |    1 
 drivers/connector/modules.builtin                  |    1 
 drivers/gpio/modules.builtin                       |    1 
 drivers/hid/modules.builtin                        |    2 
 drivers/hid/usbhid/modules.builtin                 |    1 
 drivers/i2c/busses/modules.builtin                 |    1 
 drivers/i2c/modules.builtin                        |    3 
 drivers/input/keyboard/modules.builtin             |    2 
 drivers/input/modules.builtin                      |    5 
 drivers/input/serio/modules.builtin                |    3 
 drivers/input/touchscreen/modules.builtin          |    1 
 drivers/mmc/card/modules.builtin                   |    1 
 drivers/mmc/core/modules.builtin                   |    1 
 drivers/mmc/host/modules.builtin                   |    1 
 drivers/mmc/modules.builtin                        |    3 
 drivers/modules.builtin                            |   38 
 drivers/net/modules.builtin                        |    4 
 drivers/net/phy/modules.builtin                    |    2 
 drivers/power/modules.builtin                      |    1 
 drivers/rtc/modules.builtin                        |    2 
 drivers/scsi/modules.builtin                       |    2 
 drivers/serial/modules.builtin                     |    2 
 drivers/spi/modules.builtin                        |    1 
 drivers/staging/Kconfig                            |    2 
 drivers/staging/Makefile                           |    1 
 drivers/staging/westbridge/Kconfig                 |   34 
 drivers/staging/westbridge/astoria/Kconfig         |    9 
 drivers/staging/westbridge/astoria/Makefile        |   11 
 drivers/staging/westbridge/astoria/api/Makefile    |   10 
 drivers/staging/westbridge/astoria/block/Kconfig   |    9 
 drivers/staging/westbridge/astoria/block/Makefile  |   11 
 drivers/staging/westbridge/astoria/device/Kconfig  |    9 
 drivers/staging/westbridge/astoria/device/Makefile |   14 
 drivers/staging/westbridge/astoria/gadget/Kconfig  |    8 
 drivers/staging/westbridge/astoria/gadget/Makefile |   11 
 drivers/usb/core/modules.builtin                   |    1 
 drivers/usb/modules.builtin                        |    2 
 drivers/usb/mon/modules.builtin                    |    1 
 drivers/usb/musb/modules.builtin                   |    1 
 drivers/usb/otg/modules.builtin                    |    1 
 drivers/w1/modules.builtin                         |    1 
 fs/ext2/modules.builtin                            |    1 
 fs/ext3/modules.builtin                            |    1 
 fs/fat/inode.c                                     |    1 
 fs/fat/modules.builtin                             |    3 
 fs/jbd/modules.builtin                             |    1 
 fs/lockd/modules.builtin                           |    1 
 fs/modules.builtin                                 |   15 
 fs/mpage.c                                         |   17 
 fs/nfs/modules.builtin                             |    1 
 fs/nfs_common/modules.builtin                      |    1 
 fs/nls/modules.builtin                             |    3 
 fs/quota/modules.builtin                           |    2 
 lib/modules.builtin                                |    6 
 lib/zlib_inflate/modules.builtin                   |    1 
 modules.builtin                                    |   92 
 net/ipv4/modules.builtin                           |    6 
 net/key/modules.builtin                            |    1 
 net/modules.builtin                                |   13 
 net/packet/modules.builtin                         |    1 
 net/sunrpc/auth_gss/modules.builtin                |    2 
 net/sunrpc/modules.builtin                         |    3 
 net/unix/modules.builtin                           |    1 
 net/xfrm/modules.builtin                           |    1 
 sound/core/modules.builtin                         |    1 
 sound/modules.builtin                              |    2 
 72 files changed, 12101 insertions(+), 38 deletions(-)

It's also line-wrapped, and doesn't contain a "Signed-off-by:" line so I
can't apply it :(

Oh, diffstat can't even read the diff properly, so what is above isn't
what is really all there, the driver files do seem to be there, just not
showing up properly.

Care to fix this up and retry?

thanks,

greg k-h

Re: PATCH: West Bridge Driver Kernel Support linux-2.6.35

[Greg KH]

On Fri, Aug 06, 2010 at 03:31:19PM -0700, David Cross / Applications Engineer wrote:
> 
> Re-Re-Re-sending with unnecessary files removed and line wrap turned off in
> new email client. The last one did include a Signed-off-by: at the end, I
> believe, and I am re-including here. Please let me know if there are
> formatting issues with this sign off.

Signed-off-by: goes after the body of the changelog comment, and before
the patch itself.

> This is a driver for the Cypress West Bridge companion chip. Its function is
> analogous to the North/South Bridges of PC environments applied to embedded
> devices, in that it expands I/O and storage capabilities of an embedded
> processor. The Astoria version, which this driver applies to, functions as a
> USB, embedded memory and SDIO controller. The kernel that this patch was
> applied to is linux-2.6.35, although it was tested using the android kernel
> 2.6.29 running on the Zoom 2 platform. In this system, it was used primarily
> as a sideloading accelerator enabling direct data transfers between a USB host
> PC and embedded memory without system overheads.
> Minor modifications were also made to the kernel for this patch. These include
> changes such as EXPORTing of fat_get_block in the kernel code. Another
> function, mpage_cleardirty was also added to the memory management code. This
> function is used to clear the dirty pages from a specific inode. This allows
> for direct, file based DMA. None of these changes are believed to have any
> negative impact on the kernel and may provide additional benefit for other
> developers and drivers.
> The driver, as submitted, was placed into the drivers/staging/westbridge
> folder as the directory structure it will eventually reside in is not yet
> defined. The driver, as placed in staging is divided into four parts:
> 1) gadget – this implements a gadget peripheral controller and includes IOCTLs
> for MTP transfers
> 2) block – this implements a generic block device driver to enable access to
> embedded memory
> 3) api – this is the Cypress SDK, and includes USB and Storage specific
> functions. In addition, it includes common code for low level routines such as
> message passing and common data transfer routines
> 4) hal – this should likely be included in the arch directory as it needs to
> be modified for a given platform. The directory structure in the staging area
> is meant to reflect the eventual location of where this code likely should be.
> It is platform specific. In this case, the HAL included is for the Android
> Zoom 2 platform. Here, West Bridge is connected to the GPMC (general purpose
> memory controller) of the OMAP3. Specific timing needs to be enabled to ensure
> reliable communication.
> Many thanks to Greg KH for conducting initial reviews and providing pointers.
> Please contact david.cross@cypress.com for questions, concerns or feedback.
> 
> Binary files linux-2.6-35-vanilla/arch/arm/boot/compressed/piggy.gzip and
> linux-2.6-35_incl_sdk/arch/arm/boot/compressed/piggy.gzip differ
> diff -uprN -X linux-2.6-35-vanilla/Documentation/dontdiff
> linux-2.6-35-vanilla/arch/arm/mach-omap2/gpmc.c
> linux-2.6-35_incl_sdk/arch/arm/mach-omap2/gpmc.c
> --- linux-2.6-35-vanilla/arch/arm/mach-omap2/gpmc.c	2010-08-03
> 14:40:10.000000000 -0700

The patch is still line-wrapped and you have files in your diff that
shouldn't be (i.e. the "binary" files above.)

Care to redo it?

Also, I need a TODO file in the driver directory that details what needs
to be done in order to move the code into the main portion of the
kernel.  Take a look at the other drivers/staging/*/TODO files for
examples of the format and content.

thanks,

greg k-h

Re: PATCH: West Bridge Driver Kernel Support linux-2.6.35

[Greg KH]

On Fri, Aug 06, 2010 at 11:24:39AM -0700, David Cross wrote:
> Binary files linux-2.6-35-vanilla/arch/arm/boot/compressed/piggy.gzip and
> linux-2.6-35_incl_sdk/arch/arm/boot/compressed/piggy.gzip differ

Your patch contains a bunch of stuff you don't need, like this.

> diff -uprN -X linux-2.6-35-vanilla/Documentation/dontdiff
> linux-2.6-35-vanilla/block/modules.builtin
> linux-2.6-35_incl_sdk/block/modules.builtin

And this.

> diff -uprN -X linux-2.6-35-vanilla/Documentation/dontdiff
> linux-2.6-35-vanilla/drivers/connector/modules.builtin
> linux-2.6-35_incl_sdk/drivers/connector/modules.builtin

And so on.

You should fix this up before resending.

It looks like no one has updated the dontdiff file in a while, now that
we are all using git :)

thanks,

greg k-h