From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754559Ab0HGVsL (ORCPT ); Sat, 7 Aug 2010 17:48:11 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:47357 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733Ab0HGVsI (ORCPT ); Sat, 7 Aug 2010 17:48:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=nl8vlannBQvzv791Im6GcU47wJyBoZmSY6hN3ru1taVDWT1yOR6Uf62+K/4D9fgjmU Ax35fG7MHRsynv0vD3n0z5wzkyufh3XrQtOQlEwe5/FHBWJ4Wt/8eSgQzUpJcUcKK+OT 2Vqdqndswz/El33+3A4troZMpRgXPvgpEWb18= Date: Sun, 8 Aug 2010 01:48:03 +0400 From: Cyrill Gorcunov To: Ingo Molnar Cc: LKML , Lin Ming , Stephane Eranian , Peter Zijlstra , Frederic Weisbecker , "H. Peter Anvin" Subject: Re: [PATCH] perf,x86: P4 PMU -- update nmi irq statistics and unmask lvt entry properly Message-ID: <20100807214803.GC10428@lenovo> References: <20100805150917.GA6311@lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100805150917.GA6311@lenovo> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 05, 2010 at 07:09:17PM +0400, Cyrill Gorcunov wrote: > In case if last active performance counter is not overflowed at > moment of NMI being triggered by another counter, the irq statistics > may miss an update stage. As a more serious consequence -- apic quirk > may not be triggered so apic lvt entry stay masked. > > Tested-by: Lin Ming > Signed-off-by: Cyrill Gorcunov > CC: Lin Ming > CC: Stephane Eranian > CC: Peter Zijlstra > CC: Ingo Molnar > CC: Frederic Weisbecker > --- Ping? Frederic, perhaps you'll pick it up? -- Cyrill