From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754657Ab0HGWO2 (ORCPT ); Sat, 7 Aug 2010 18:14:28 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:65037 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064Ab0HGWO0 (ORCPT ); Sat, 7 Aug 2010 18:14:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=BCyoYV4ynveT2z4Iz8NNVenvWDAC3xtduBZbf7bcwnTMUIUapIDdz0MuGutpyQhyZy N8YaiuT8x8aV2YdeNwolRxb2XnjVuzPePASPc/kTzLVsV1iOO1By1bFugI/kQ5K09D1N Ch6V7UG5didsbTPZ6O4NVV29rhWDrMLW7xJP4= Date: Sun, 8 Aug 2010 00:13:58 +0200 From: Dan Carpenter To: Jing Huang Cc: "James E.J. Bottomley" , Krishna Gudipati , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] bfa: dereferencing before testing Message-ID: <20100807221358.GB9031@bicker> Mail-Followup-To: Dan Carpenter , Jing Huang , "James E.J. Bottomley" , Krishna Gudipati , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I moved the dereference of "port" after the check to verify it was non-NULL. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/bfa/lport_api.c b/drivers/scsi/bfa/lport_api.c index 72b3f50..5cd356a 100644 --- a/drivers/scsi/bfa/lport_api.c +++ b/drivers/scsi/bfa/lport_api.c @@ -149,11 +149,12 @@ bfa_fcs_port_get_rport_max_speed(struct bfa_fcs_port_s *port) enum bfa_pport_speed max_speed = 0; struct bfa_pport_attr_s pport_attr; enum bfa_pport_speed pport_speed, rport_speed; - bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa); + bfa_boolean_t trl_enabled; if (port == NULL) return 0; + trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa); fcs = port->fcs; /*