From: David Miller <davem@davemloft.net>
To: dilinger@queued.net
Cc: grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sparc: make driver/of/pdt no longer sparc-specific
Date: Sun, 08 Aug 2010 22:34:44 -0700 (PDT) [thread overview]
Message-ID: <20100808.223444.62324566.davem@davemloft.net> (raw)
In-Reply-To: <20100809013245.1cefb9bf@dev.queued.net>
From: Andres Salomon <dilinger@queued.net>
Date: Mon, 9 Aug 2010 01:32:45 -0400
> On Sun, 8 Aug 2010 23:12:21 -0600
> Grant Likely <grant.likely@secretlab.ca> wrote:
>
>> If you have to explicitly cast these function pointers, then you're
>> doing it wrong. :-) Listen to and fix the compiler complaint here.
>>
>
> Hm, can you please expand on that? The reason it's necessary to cast is
> because sparc's prom_* functions are using ints instead of phandles. I
> don't understand why casting is the wrong thing here.
>
> I could write some 1-line wrapper functions that simply call prom_*
> rather than casting, I suppose.
There's no reason the Sparc interfaces can't take phandles since they
are just ints, and that would make the call signatures of these
functions compatible with the types used by the other architectures.
next prev parent reply other threads:[~2010-08-09 5:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 3:11 [PATCH 2/3] sparc: make driver/of/pdt no longer sparc-specific Andres Salomon
2010-08-09 5:12 ` Grant Likely
2010-08-09 5:32 ` Andres Salomon
2010-08-09 5:34 ` David Miller [this message]
2010-08-16 4:22 ` Andres Salomon
2010-08-16 6:17 ` David Miller
2010-08-09 5:41 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100808.223444.62324566.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dilinger@queued.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox