From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
Date: Mon, 9 Aug 2010 11:15:31 +0200 [thread overview]
Message-ID: <20100809091530.GB2513@sortiz-mobl> (raw)
In-Reply-To: <1281336496.18804.2.camel@mola>
Hi Axel,
On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> The i2c_client received in probe() should not be kfree()'d.
This should go through Liam's tree, I'm CC'ing him to this thread.
Cheers,
Samuel.
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/max8998.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 0d68de2..73e6f5c 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
> int ret = 0;
>
> max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
> - if (max8998 == NULL) {
> - kfree(i2c);
> + if (max8998 == NULL)
> return -ENOMEM;
> - }
>
> i2c_set_clientdata(i2c, max8998);
> max8998->dev = &i2c->dev;
> --
> 1.5.4.3
>
>
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-08-09 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 6:48 [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler Axel Lin
2010-08-09 9:15 ` Samuel Ortiz [this message]
2010-08-09 9:36 ` Liam Girdwood
2010-08-09 9:44 ` Samuel Ortiz
2010-08-09 10:05 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809091530.GB2513@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox