public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Li Zefan <lizf@cn.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] lockup_detector: Make DETECT_HUNT_TASK default depend on LOCKUP_DETECTOR
Date: Mon, 9 Aug 2010 16:21:21 +0200	[thread overview]
Message-ID: <20100809142121.GD2169@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20100809134917.GD2604@redhat.com>

On Mon, Aug 09, 2010 at 09:49:17AM -0400, Don Zickus wrote:
> > > Why s390 doesn't want the softlockup detector to begin with?
> > 
> > If I remember correctly then we disabled that back then because we got
> > false positives. The reason for those were that the softlockup detector
> > did not take steal time into account.
> > E.g. if a guest cpu runs for 10 seconds, but the hypervisor would steal
> > 9 seconds in order to run other guest cpus this specific cpu would still
> > think it ran for 10 seconds and therefore would generate invalid warnings.
> 
> I have learned recently that is applies to all virtual machines including
> KVM, Xen and VMWare(?).  However, you only see this when you overload the
> hypervisor with lots of guests.  Which is why you normally don't see this
> on those types of guests.

On s390 you always run virtualized and usually even as a 2nd level guest.
Overloading a machine is quite common here.
The problem we have is that you can't tell afterwards if a warning was valid
or invalid due to overloading. Imho it is just pointless without taking steal
time into account and that's why we disabled it.

  reply	other threads:[~2010-08-09 14:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04  1:53 [PATCH] lockup_detector: Make DETECT_HUNT_TASK default depend on LOCKUP_DETECTOR Li Zefan
2010-08-06  0:58 ` Frederic Weisbecker
2010-08-07  7:01   ` Ingo Molnar
2010-08-08 19:58     ` Frederic Weisbecker
2010-08-08 21:23       ` Ingo Molnar
2010-08-08 21:47         ` Frederic Weisbecker
2010-08-09  8:07       ` Heiko Carstens
2010-08-09 13:49         ` Don Zickus
2010-08-09 14:21           ` Heiko Carstens [this message]
2010-08-17  6:03       ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100809142121.GD2169@osiris.boeblingen.de.ibm.com \
    --to=heiko.carstens@de.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox