public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Miles Lane <miles.lane@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection!
Date: Mon, 9 Aug 2010 09:30:44 -0700	[thread overview]
Message-ID: <20100809163044.GD3026@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>

On Sun, Jul 04, 2010 at 06:04:20PM -0400, Miles Lane wrote:
> [ 1619.938226] [ INFO: suspicious rcu_dereference_check() usage. ]
> [ 1619.938230] ---------------------------------------------------
> [ 1619.938235] include/linux/fdtable.h:88 invoked
> rcu_dereference_check() without protection!
> [ 1619.938239]
> [ 1619.938240] other info that might help us debug this:
> [ 1619.938242]
> [ 1619.938245]
> [ 1619.938246] rcu_scheduler_active = 1, debug_locks = 1
> [ 1619.938250] no locks held by dbus-daemon/4254.
> [ 1619.938253]
> [ 1619.938254] stack backtrace:
> [ 1619.938260] Pid: 4254, comm: dbus-daemon Not tainted 2.6.35-rc3-git8 #5
> [ 1619.938264] Call Trace:
> [ 1619.938277]  [<ffffffff8106756a>] lockdep_rcu_dereference+0x9d/0xa6
> [ 1619.938286]  [<ffffffff810cae92>] fcheck_files+0xb1/0xca
> [ 1619.938292]  [<ffffffff810caf03>] fget_light+0x35/0x96
> [ 1619.938300]  [<ffffffff810d8d5e>] do_sys_poll+0x1ff/0x3e5
> [ 1619.938307]  [<ffffffff810d8572>] ? __pollwait+0x0/0xc7
> [ 1619.938314]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938320]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938327]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938333]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938340]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938346]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938353]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938359]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938365]  [<ffffffff810d8639>] ? pollwake+0x0/0x4f
> [ 1619.938374]  [<ffffffff810d90d8>] sys_poll+0x50/0xba
> [ 1619.938383]  [<ffffffff81009c82>] system_call_fastpath+0x16/0x1b

Hello, Miles!

Thank you again for your continued testing!

I believe that this one has been fixed by commit 844b9a8707f, which was
added in v2.6.35-rc6.  This commit added rcu_my_thread_group_empty()
to the list of rcu_dereference_check() conditions in the
rcu_dereference_check_fdtable() macro.

							Thanx, Paul

      reply	other threads:[~2010-08-09 16:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-04 22:04 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection! Miles Lane
2010-08-09 16:30 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100809163044.GD3026@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox