From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: gpio-addr-flash warnings on x86/highmem (Re: i386 allmodconfig, current mainline)
Date: Mon, 9 Aug 2010 17:07:09 -0700 [thread overview]
Message-ID: <20100809170709.9c16c756.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTikjeQ=b7c85R0-yVzSOiMKWbWksnBRiz0wmOaN2@mail.gmail.com>
On Mon, 9 Aug 2010 19:52:35 -0400
Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Mon, Aug 9, 2010 at 19:43, Andrew Morton wrote:
> > Guys. __What's goin' on out there?
> >
> > drivers/mtd/maps/gpio-addr-flash.c: In function 'gpio_flash_probe':
> > drivers/mtd/maps/gpio-addr-flash.c:212: warning: cast to pointer from integer of different size
> > drivers/mtd/maps/gpio-addr-flash.c:224: warning: cast to pointer from integer of different size
>
> i did get a bug report about this in the past, but honestly i havent
> gotten around to fixing the issues. it's been low priority as my
> understanding is that the warning shows up in configurations where the
> driver isnt realistically usable. not making excuses, just laying out
> the reality of things.
Casting a resource_size_t to a kernel pointer is plain naughty.
I guess an acceptable "fix" would be to disable to offending combinations
in Kconfig and add a
BUILD_BUG_ON(sizeof(gpios->start) != sizeof(void *))
to catch stragglers.
But please do fix warnings, if only because the warning storm from
allmodconfig causes people to miss important warnings in all the noise.
next prev parent reply other threads:[~2010-08-10 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 23:52 gpio-addr-flash warnings on x86/highmem (Re: i386 allmodconfig, current mainline) Mike Frysinger
2010-08-10 0:07 ` Andrew Morton [this message]
2010-08-10 0:12 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809170709.9c16c756.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox