From: Vasiliy Kulikov <segooon@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.hengli.com.au, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: n2 RNG driver bogus cast removal
Date: Mon, 9 Aug 2010 23:32:46 +0400 [thread overview]
Message-ID: <20100809193246.GA11374@albatros> (raw)
In-Reply-To: <20100809.004514.73697921.davem@davemloft.net>
On Mon, Aug 09, 2010 at 00:45 -0700, David Miller wrote:
>
> Kulikov, can you at least build test your patches? Casts are not
> always incorrect, particularly when private cookies are "unsigned
> long" as is the case here:
>
> drivers/char/hw_random/n2-drv.c: In function ‘n2rng_data_read’:
> drivers/char/hw_random/n2-drv.c:390: warning: initialization makes pointer from integer without a cast
Ahh, shame on me... I'd compiled this on x86 and looked through error
log, I wrongly pointed out that there is no error at this line. As I see
now, this tactic is incorrect. I'd not do this any more, sorry for
this...
>
> Herbert, please revert this change, thanks. And I suspect there
> might be more of these hwrng driver duds that went into the tree,
> it's worth checking out. :-)
>
> Thanks.
>
> commit 8b9cfdca9c52f7d39c3ccfac1668e31c20c9f42e
> Author: Kulikov Vasiliy <segooon@gmail.com>
> Date: Mon Jul 5 21:25:06 2010 +0800
>
> hwrng: n2-drv - remove casts from void*
>
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
prev parent reply other threads:[~2010-08-09 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 7:45 n2 RNG driver bogus cast removal David Miller
2010-08-09 14:26 ` Herbert Xu
2010-08-09 19:32 ` Vasiliy Kulikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809193246.GA11374@albatros \
--to=segooon@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).