From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Christian Dietrich <qy03fugy@stud.informatik.uni-erlangen.de>
Cc: David Howells <dhowells@redhat.com>, Tejun Heo <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vamos-dev@i4.informatik.uni-erlangen.de"
<vamos-dev@i4.informatik.uni-erlangen.de>
Subject: Re: [PATCH 1/4] arch/frv: Removing dead RAMKERNEL config option
Date: Tue, 10 Aug 2010 12:37:17 +0300 [thread overview]
Message-ID: <20100810093717.GD22436@nokia.com> (raw)
In-Reply-To: <c80d5af9b2921e9d8cc6d8d7b9a54a882f1c919e.1281431005.git.qy03fugy@stud.informatik.uni-erlangen.de>
Hi,
On Tue, Aug 10, 2010 at 11:11:08AM +0200, ext Christian Dietrich wrote:
>diff --git a/arch/frv/mm/init.c b/arch/frv/mm/init.c
>index ed64588..73586ad 100644
>--- a/arch/frv/mm/init.c
>+++ b/arch/frv/mm/init.c
>@@ -170,23 +170,6 @@ void __init mem_init(void)
> */
> void free_initmem(void)
> {
>-#if defined(CONFIG_RAMKERNEL) && !defined(CONFIG_PROTECT_KERNEL)
>- unsigned long start, end, addr;
>-
>- start = PAGE_ALIGN((unsigned long) &__init_begin); /* round up */
>- end = ((unsigned long) &__init_end) & PAGE_MASK; /* round down */
>-
>- /* next to check that the page we free is not a partial page */
>- for (addr = start; addr < end; addr += PAGE_SIZE) {
>- ClearPageReserved(virt_to_page(addr));
>- init_page_count(virt_to_page(addr));
>- free_page(addr);
>- totalram_pages++;
>- }
>-
>- printk("Freeing unused kernel memory: %ldKiB freed (0x%lx - 0x%lx)\n",
>- (end - start) >> 10, start, end);
>-#endif
> } /* end free_initmem() */
and now you have an empty function... how about removing the function
completely and it's uses ?
--
balbi
DefectiveByDesign.org
next prev parent reply other threads:[~2010-08-10 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 9:11 [PATCH 0/4] Removing dead code Christian Dietrich
2010-08-10 9:11 ` [PATCH 1/4] arch/frv: Removing dead RAMKERNEL config option Christian Dietrich
2010-08-10 9:37 ` Felipe Balbi [this message]
2010-08-10 10:54 ` Christian Dietrich
2010-08-10 11:54 ` Felipe Balbi
2010-08-10 9:11 ` [PATCH 2/4] arch/frv: Removing dead HEARTBEAT " Christian Dietrich
2010-08-10 9:35 ` Felipe Balbi
2010-08-10 11:06 ` Christian Dietrich
2010-08-10 9:11 ` [PATCH 3/4] arch/frv: Removing dead NO_KERNEL_MSG " Christian Dietrich
2010-08-10 9:11 ` [PATCH 4/4] arch/frv: Removing dead DEBUG_STACK_USAGE " Christian Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810093717.GD22436@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qy03fugy@stud.informatik.uni-erlangen.de \
--cc=tj@kernel.org \
--cc=vamos-dev@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox