Re: [2.6.35] AMD-Vi: Enabling IOMMU at 0000:00:00.2 cap 0x40 BUG: unable to handle kernel NULL pointer dereference at 0000000000000198

[Joerg Roedel <joro@8bytes.org>]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

On Tue, Aug 10, 2010 at 11:36:59PM +0200, Sander Eikelenboom wrote:
> It boots now, dmesg attached.

Ok, here is a quick and dirty patch wich should make your system boot
again. It introduces other issues which will show up when you try to
assign the devices to a virtual machine. But at least the devices should
work again on bare-metal.

	Joerg


[-- Attachment #2: iommu-alias-fix.diff --]
[-- Type: text/x-diff, Size: 1935 bytes --]

diff --git a/arch/x86/include/asm/amd_iommu_types.h b/arch/x86/include/asm/amd_iommu_types.h
index 7014e88..b667e80 100644
--- a/arch/x86/include/asm/amd_iommu_types.h
+++ b/arch/x86/include/asm/amd_iommu_types.h
@@ -285,6 +285,8 @@ struct protection_domain {
 
 };
 
+#define INVALID_ALIAS_ID (~0U)
+
 /*
  * This struct contains device specific data for the IOMMU
  */
@@ -294,6 +296,9 @@ struct iommu_dev_data {
 	struct device *alias;		  /* The Alias Device */
 	struct protection_domain *domain; /* Domain the device is bound to */
 	atomic_t bind;			  /* Domain attach reverent count */
+
+	u32	alias_id;		  /* Use in case device aliases to
+					     non-existend PCI BDF */
 };
 
 /*
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 0d20286..673d0a4 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -148,11 +148,17 @@ static int iommu_init_device(struct device *dev)
 
 	dev_data->dev = dev;
 
+	dev_data->alias_id = INVALID_ALIAS_ID;
+
 	devid = get_device_id(dev);
 	alias = amd_iommu_alias_table[devid];
 	pdev = pci_get_bus_and_slot(PCI_BUS(alias), alias & 0xff);
 	if (pdev)
 		dev_data->alias = &pdev->dev;
+	else {
+		dev_data->alias = dev;
+		dev_data->alias_id = alias;
+	}
 
 	atomic_set(&dev_data->bind, 0);
 
@@ -1448,6 +1454,9 @@ static void do_attach(struct device *dev, struct protection_domain *domain)
 	list_add(&dev_data->list, &domain->dev_list);
 	set_dte_entry(devid, domain);
 
+	if (dev_data->alias_id != INVALID_ALIAS_ID)
+		set_dte_enry(dev_data->alias_id, domain);
+
 	/* Do reference counting */
 	domain->dev_iommu[iommu->index] += 1;
 	domain->dev_cnt                 += 1;
@@ -1475,6 +1484,9 @@ static void do_detach(struct device *dev)
 	list_del(&dev_data->list);
 	clear_dte_entry(devid);
 
+	if (dev_data->alias_id != INVALID_ALIAS_ID)
+		clear_dte_enry(dev_data->alias_id);
+
 	/* Flush the DTE entry */
 	iommu_flush_device(dev);
 }