From: Rusty Russell <rusty@rustcorp.com.au>
To: Dmitry Torokhov <dtor@vmware.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 1/2] param: allow omitting set() methods for truly read-only params
Date: Wed, 11 Aug 2010 11:09:30 +0930 [thread overview]
Message-ID: <201008111109.30433.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1281466725-22549-1-git-send-email-dtor@vmware.com>
On Wed, 11 Aug 2010 04:28:44 am Dmitry Torokhov wrote:
> Certain "parameters", such as acpica version and upcoming VMware Balloon
> version, are need to be purely read-only. They are exported as
> parameters so that they are visible in sysfs even in cases when the
> module is built directly into the kernel, but their values should be
> immutable. Specifying S_IRUGO takes care of sysfs interface, but it
> has no effect on kernel command line or modprobe configuration files and
> so these "parameters" attempt to omit set() method. Unfortunately
> kernel expects set() to be always present and crashes if it is not
> there, so let's add appropriate check.
>
> Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
That almost makes sense, but not quite.
Your followup patch uses this for version, but the version is already
in /sys/module/vmware_balloon/version as is standard with modules, no?
Confused,
Rusty.
next prev parent reply other threads:[~2010-08-11 1:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 18:58 [PATCH 1/2] param: allow omitting set() methods for truly read-only params Dmitry Torokhov
2010-08-10 18:58 ` [PATCH 2/2] VMware balloon: export module version as module parameter Dmitry Torokhov
2010-08-11 1:39 ` Rusty Russell [this message]
2010-08-11 7:35 ` [PATCH 1/2] param: allow omitting set() methods for truly read-only params Dmitry Torokhov
2010-08-11 10:49 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008111109.30433.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=dtor@vmware.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox