From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758141Ab0HKJ2U (ORCPT ); Wed, 11 Aug 2010 05:28:20 -0400 Received: from hanwang.com.cn ([221.122.51.51]:40150 "EHLO mail.hanwang.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758109Ab0HKJ2R (ORCPT ); Wed, 11 Aug 2010 05:28:17 -0400 Date: Wed, 11 Aug 2010 17:27:33 +0800 From: "Xing Wei" To: "Jiri Kosina" Cc: "linux-input" , "linux-kernel" References: <201008111148203123394@hanwang.com.cn>, Subject: Re: Re: [PATCH] drivers/hid: the support for Hanwang tablet Message-ID: <201008111727331714570@hanwang.com.cn> X-mailer: Foxmail 6, 15, 201, 23 [cn] Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id o7B9SgYm000946 ok,i'll fix it and submit it with driver later. The driver is just using usb bus. ------------------------------------------------------------- 发件人：Jiri Kosina 发送日期：2010-08-11 15:34:49 收件人：Xing Wei 抄送：linux-input; linux-kernel 主题：Re: [PATCH] drivers/hid: the support for Hanwang tablet On Wed, 11 Aug 2010, Xing Wei wrote: > From: Xing Wei > > This patch is the support for tablet of BeiJing HanwangTechnology Co, Ltd. > The main purpose is to make the device taken over by our driver. > The driver code will be submitted later. > > Signed-off-by: Xing Wei > > --- > This is our first time to submit the patch for linux.We'll really appreciate the comment and advice. > > diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-core.c devel/linux-2.6.35/drivers/hid/hid-core.c > --- linux-2.6.35-vanilla/drivers/hid/hid-core.c 2010-08-02 06:11:14.000000000 +0800 > +++ devel/linux-2.6.35/drivers/hid/hid-core.c 2010-08-11 18:20:13.832088816 +0800 > @@ -1759,6 +1759,11 @@ static bool hid_ignore(struct hid_device > hdev->product <= USB_DEVICE_ID_SOUNDGRAPH_IMON_LAST) > return true; > break; > + case USB_VENDOR_ID_HANWANG: > + if (hdev->product >= USB_DEVICE_ID_HANWANG_TABLET_FIRST && > + hdev->product <= USB_DEVICE_ID_HANWANG_TABLET_LAST) > + return true; > + break; > } > > if (hdev->type == HID_TYPE_USBMOUSE && > diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-ids.h devel/linux-2.6.35/drivers/hid/hid-ids.h > --- linux-2.6.35-vanilla/drivers/hid/hid-ids.h 2010-08-02 06:11:14.000000000 +0800 > +++ devel/linux-2.6.35/drivers/hid/hid-ids.h 2010-08-11 18:17:32.967089161 +0800 > @@ -526,5 +526,8 @@ > #define USB_DEVICE_ID_KYE_ERGO_525V 0x0087 > #define USB_DEVICE_ID_KYE_GPEN_560 0x5003 > > +#define USB_VENDOR_ID_HANWANG 0x0b57 > +#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff > +#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000 The patch is fine (I'd only suggest swapping 'LAST' and 'FIRST' lines here to keep proper ordering), but I will be applying it only together with the driver once you submit it, as it doesn't make sense stand-alone. The driver is not HID-based (i.e. not using hid bus), but completely standalone, right? -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html 翳簕.n+壏煯壄+%娝遍荻w簕.n+壏{炳G珴妠ay蕠跈,jf＂穐殢飦戧鐉_璁(殠娸"濟mG珴⒏?櫒璀&ｘ忈秈O曟瑉窔v豝m 鹅⒏?朓