public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* re: fsnotify: pass both the vfsmount mark and inode mark
@ 2010-08-11 18:51 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-08-11 18:51 UTC (permalink / raw)
  To: eparis; +Cc: linux-kernel

There is a NULL dereference introduced in ce8f76fb7320 "fsnotify: pass
both the vfsmount mark and inode mark"

   143  static int send_to_group(struct inode *to_tell, struct vfsmount *mnt,
   144                           struct fsnotify_mark *inode_mark,
   145                           struct fsnotify_mark *vfsmount_mark,
   146                           __u32 mask, void *data,
   147                           int data_is, u32 cookie,
   148                           const unsigned char *file_name,
   149                           struct fsnotify_event **event)
   150  {
   151          struct fsnotify_group *group = inode_mark->group;
                                               ^^^^^^^^^^^^^^^^^^
	inode_mark can be NULL.

   152          __u32 inode_test_mask = (mask & ~FS_EVENT_ON_CHILD);
   153          __u32 vfsmount_test_mask = (mask & ~FS_EVENT_ON_CHILD);

I'm not sure how to handle this.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-11 18:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-11 18:51 fsnotify: pass both the vfsmount mark and inode mark Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox