From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757940Ab0HLRGq (ORCPT ); Thu, 12 Aug 2010 13:06:46 -0400 Received: from 8bytes.org ([88.198.83.132]:50085 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822Ab0HLRGp (ORCPT ); Thu, 12 Aug 2010 13:06:45 -0400 Date: Thu, 12 Aug 2010 19:06:44 +0200 From: Joerg Roedel To: "H. Peter Anvin" Cc: "Roedel, Joerg" , Borislav Petkov , "mingo@elte.hu" , "tglx@linutronix.de" , "Herrmann3, Andreas" , "Seidel, Conny" , "Sarathy, Bhavna" , "greg@kroah.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] x86-32: Fix crashes with CPU hotplug on AMD machines Message-ID: <20100812170644.GZ23755@8bytes.org> References: <1280940316-7966-1-git-send-email-bp@amd64.org> <1280940316-7966-2-git-send-email-bp@amd64.org> <4C59F24B.1010702@zytor.com> <20100805074503.GI18307@amd.com> <4C5AC736.20903@zytor.com> <20100812144142.GY23755@8bytes.org> <4C64148D.5080305@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C64148D.5080305@zytor.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 12, 2010 at 08:34:37AM -0700, H. Peter Anvin wrote: > Agreed. I do have a concern about the kernel page tables not being > synchronized into trampoline_pg_dir (it's only an issue for 32-bit > !PAE), so at the very least we need to keep an eye out for it... Great. The synchronization problem might be real. The cpu_init function uses per-cpu variables which might not be present in the early synced tramponline page table (iirc). The change to swapper_pg_dir and the global tlb flush should probably be moved to the very beginning of the start_secondary function. Joerg