From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: eranian@google.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
fweisbec@gmail.com, peterz@infradead.org
Subject: Re: [PATCH] perf trace: get rid of the hard-coded paths in the report scripts
Date: Thu, 12 Aug 2010 15:20:00 -0300 [thread overview]
Message-ID: <20100812182000.GD21829@ghostprotocols.net> (raw)
In-Reply-To: <1281635958-21177-1-git-send-email-tzanussi@gmail.com>
Em Thu, Aug 12, 2010 at 12:59:18PM -0500, Tom Zanussi escreveu:
> The perf trace report shell scripts hard-code the exec path of the
> scripts into their command-lines, which doesn't work if perf has been
> installed somewhere else.
>
> Instead, perf trace should create the paths at run-time. This patch
> does that and removes the hard-coded paths from all the report scripts.
>
> v2 changes: The first version inadvertantly caused scripts run from
> outside the perf exec path to fail e.g. 'perf trace -s test.py'. The
> fix is to try the script name without the exec path first, then the
> version using the exec path, which restores the expected behavior.
>
> Reported-by: Stephane Eranian <eranian@google.com>
> Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Stephane,
Lemme know when you tried this patch so that I can merge it with
a Tested-by: you tag, ok?
- Arnaldo
next prev parent reply other threads:[~2010-08-12 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 17:59 [PATCH] perf trace: get rid of the hard-coded paths in the report scripts Tom Zanussi
2010-08-12 18:20 ` Arnaldo Carvalho de Melo [this message]
2010-08-12 21:29 ` Stephane Eranian
2010-08-12 21:28 ` Stephane Eranian
2010-08-12 21:50 ` Tom Zanussi
2010-08-13 8:30 ` Stephane Eranian
2010-08-14 4:38 ` Tom Zanussi
-- strict thread matches above, loose matches on Subject: below --
2010-06-18 4:41 Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812182000.GD21829@ghostprotocols.net \
--to=acme@infradead.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox