* [PATCH 21/42] drivers/pci: Adjust confusing if indentation
@ 2010-08-05 20:23 Julia Lawall
2010-08-13 23:32 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2010-08-05 20:23 UTC (permalink / raw)
To: Jesse Barnes, linux-pci, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Indent the branch of an if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 7fa3cbd..cc232c0 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2689,7 +2689,7 @@ int pcie_get_readrq(struct pci_dev *dev)
ret = pci_read_config_word(dev, cap + PCI_EXP_DEVCTL, &ctl);
if (!ret)
- ret = 128 << ((ctl & PCI_EXP_DEVCTL_READRQ) >> 12);
+ ret = 128 << ((ctl & PCI_EXP_DEVCTL_READRQ) >> 12);
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 21/42] drivers/pci: Adjust confusing if indentation
2010-08-05 20:23 [PATCH 21/42] drivers/pci: Adjust confusing if indentation Julia Lawall
@ 2010-08-13 23:32 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2010-08-13 23:32 UTC (permalink / raw)
To: Julia Lawall; +Cc: linux-pci, linux-kernel, kernel-janitors
On Thu, 5 Aug 2010 22:23:16 +0200 (CEST)
Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Indent the branch of an if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
Applied to my linux-next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-13 23:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-05 20:23 [PATCH 21/42] drivers/pci: Adjust confusing if indentation Julia Lawall
2010-08-13 23:32 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).