From: Greg KH <gregkh@suse.de>
To: David Cross <david.cross@cypress.com>
Cc: hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org
Subject: Re: EXPORT_SYMBOL(fat_get_block)
Date: Fri, 13 Aug 2010 10:54:02 -0700 [thread overview]
Message-ID: <20100813175402.GA15024@suse.de> (raw)
In-Reply-To: <1281721539.5839.4.camel@odc-laptop>
On Fri, Aug 13, 2010 at 10:45:39AM -0700, David Cross wrote:
> Hello Hirofumi,
> I would like to export this symbol from the vfat code and add this patch
> to the Linux kernel. You are listed as the MAINTAINER for FAT and VFAT.
> As such, I need your approval to do it.
> The reason that I need to export this symbol is to allow for file based
> DMA in which the file needs to be pre-allocated. The pre-allocated block
> addresses are passed to a DMA engine which then directly transfers the
> data to non-volatile storage.
> Please let me know if you have any objections to exporting this symbol
> or if you need additional information from me concerning this change
> request. I am happy to answer any questions that you may have about this
> in the meantime.
Wait, _I_ have an objection to exporting this symbol.
I really don't think it is needed at this point in time, as we really
need to figure out exactly what your driver is doing to want to need to
call this function.
So please, let's not export it for now, when we get to the point that we
all agree that this driver is doing the "correct" thing, then we can
export the symbol, ok?
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-13 17:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 17:45 EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-13 17:54 ` Greg KH [this message]
2010-08-13 18:43 ` EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-13 18:50 ` EXPORT_SYMBOL(fat_get_block) Christoph Hellwig
2010-08-13 19:06 ` EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-13 19:01 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-13 19:17 ` EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-13 19:28 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-13 20:32 ` EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-13 22:17 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-13 23:22 ` EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-14 0:25 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-14 1:12 ` EXPORT_SYMBOL(fat_get_block) David Cross
2010-08-14 3:04 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-15 22:57 ` EXPORT_SYMBOL(fat_get_block) Nelson Zhang
2010-08-17 14:54 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-17 15:40 ` EXPORT_SYMBOL(fat_get_block) Christoph Hellwig
2010-08-17 15:54 ` EXPORT_SYMBOL(fat_get_block) Greg KH
2010-08-13 17:54 ` EXPORT_SYMBOL(fat_get_block) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813175402.GA15024@suse.de \
--to=gregkh@suse.de \
--cc=david.cross@cypress.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox