From: David Miller <davem@davemloft.net>
To: walken@google.com
Cc: torvalds@linux-foundation.org, tony.luck@intel.com,
dhowells@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: tasks getting stuck on mmap_sem?
Date: Tue, 17 Aug 2010 14:59:08 -0700 (PDT) [thread overview]
Message-ID: <20100817.145908.112609486.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTimLqc02xNun0QR5ZgP497mm8ZC5ZfpCUx2AGz4Y@mail.gmail.com>
From: Michel Lespinasse <walken@google.com>
Date: Tue, 17 Aug 2010 14:47:05 -0700
> On Tue, Aug 17, 2010 at 2:28 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> Oh, and it strikes me when looking at the sparc rwsem-const.h that it
>> has some unsigned constants in it. I think
>>
>> #define RWSEM_WAITING_BIAS 0xffff0000
>>
>> is actually unsigned, because it's a hex constant that doesn't fit in
>> a signed int. So it's of type 'unsigned int' if I recall the C type
>> rules right.
>
> Eeeek, this totally escaped me when I had a quick look at constant
> signed-ness across architectures. This is definitely a problem.
>
>> #define RWSEM_WAITING_BIAS (-0x00010000)
>
> David, do you still see failures with v2.6.36-rc1 plus that one line fix ?
As I said in a reply to Tony I don't even think your commit is
to blame, because even after reverting it I still have the
problems.
I'll keep digging into this.
next prev parent reply other threads:[~2010-08-17 21:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 4:12 tasks getting stuck on mmap_sem? David Miller
2010-08-17 16:14 ` Linus Torvalds
2010-08-17 18:24 ` Tony Luck
2010-08-17 20:46 ` Tony Luck
2010-08-17 21:08 ` Linus Torvalds
2010-08-17 21:26 ` Tony Luck
2010-08-17 21:28 ` Linus Torvalds
2010-08-17 21:47 ` Michel Lespinasse
2010-08-17 21:59 ` David Miller [this message]
2010-08-17 23:40 ` David Miller
2010-08-17 21:44 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-08-17 5:22 Dimitris Michailidis
2010-08-17 5:35 ` David Miller
2010-08-17 7:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817.145908.112609486.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox