From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463Ab0HQExl (ORCPT ); Tue, 17 Aug 2010 00:53:41 -0400 Received: from ozlabs.org ([203.10.76.45]:58002 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753426Ab0HQExj (ORCPT ); Tue, 17 Aug 2010 00:53:39 -0400 Date: Tue, 17 Aug 2010 13:46:34 +1000 From: Paul Mackerras To: Frederic Weisbecker Cc: LKML , Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Stephane Eranian , David Miller , Paul Mundt , Will Deacon , Borislav Petkov Subject: Re: [RFC PATCH 3/6] perf: Generalize some arch callchain code Message-ID: <20100817034634.GB24726@drongo> References: <1281991715-10367-1-git-send-regression-fweisbec@gmail.com> <1281991715-10367-4-git-send-regression-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1281991715-10367-4-git-send-regression-fweisbec@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2010 at 10:48:32PM +0200, Frederic Weisbecker wrote: > - Most archs use one callchain buffer per cpu, except x86 that needs > to deal with NMIs. Provide a default perf_callchain_buffer() > implementation that x86 overrides. > > - Centralize all the kernel/user regs handling and invoke new arch > handlers from there: perf_callchain_user() / perf_callchain_kernel() > That avoid all the user_mode(), current->mm checks and so... > > - Invert some parameters in perf_callchain_*() helpers: entry to the > left, regs to the right, following the traditional (src, dst). I think you mean (dst, src), don't you? Apart from that, the patch looks OK, so Acked-by: Paul Mackerras Paul.