From: Christoph Hellwig <hch@lst.de>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH block#for-2.6.36-post] block: fix incorrect bio/request flag conversion in md
Date: Tue, 17 Aug 2010 15:56:38 +0200 [thread overview]
Message-ID: <20100817135638.GA5382@lst.de> (raw)
In-Reply-To: <4C694965.6040805@kernel.org>
On Mon, Aug 16, 2010 at 04:21:25PM +0200, Tejun Heo wrote:
> Commit 74450be1 (block: unify flags for struct bio and struct request)
> incorrectly converted @do_sync in md raid1 and raid10 make_requst()
> functions.
>
> @do_sync is now supposed to carry the actual flag bit and directly
> OR'd into bio->bi_rw but is still a bool and thus carries either 0 or
> 1 instead of the actual flag bit. This makes REQ_SYNC ignored on
> writes and flips the direction of READ_SYNCs to WRITEs.
>
> Fix it by making @do_sync unsigned integers.
Yeah, you're the fourth person coming up with this independently. Now
all we need is to get one of the patches actually into Linus tree.
next prev parent reply other threads:[~2010-08-17 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 14:21 [PATCH block#for-2.6.36-post] block: fix incorrect bio/request flag conversion in md Tejun Heo
2010-08-17 13:56 ` Christoph Hellwig [this message]
2010-08-17 13:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817135638.GA5382@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox