From: Arnd Bergmann <arnd@arndb.de>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/do_mounts.c: replace sys_mount() to do_mount()
Date: Tue, 17 Aug 2010 15:41:46 +0200 [thread overview]
Message-ID: <201008171541.47078.arnd@arndb.de> (raw)
In-Reply-To: <1282051520.1635.7.camel@leonhard>
On Tuesday 17 August 2010, Namhyung Kim wrote:
> 2010-08-17 (화), 15:15 +0200, Arnd Bergmann:
> > AFAICT there is no need for the copy at all here. The reason that sys_mount
> > copies to a separate page is that it gets passed an arbitrary-length user
> > input.
>
> Right. But make sure to user options never exceed a page, do_mount() has
> following code:
>
> if (data_page)
> ((char *)data_page)[PAGE_SIZE - 1] = 0;
Hmm, how very unexpected...
Maybe you can fix that as well in the same patch and move this safeguard
into the copy_mount_options() function? I guess ideally we'd even mark
the arguments to do_mount() as pointers to const, but that might create
an excessive amount of churn.
Arnd
next prev parent reply other threads:[~2010-08-17 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 12:37 [PATCH] init/do_mounts.c: replace sys_mount() to do_mount() Namhyung Kim
2010-08-17 13:15 ` Arnd Bergmann
2010-08-17 13:25 ` Namhyung Kim
2010-08-17 13:41 ` Arnd Bergmann [this message]
2010-08-17 14:38 ` [PATCH v2] init: " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008171541.47078.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox