From: Frederic Weisbecker <fweisbec@gmail.com>
To: Marin Mitov <mitov@issp.bas.bg>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Andrew Benton <b3nton@gmail.com>
Subject: Re: [BUG][reiserfs] page fault during kernel boot
Date: Wed, 18 Aug 2010 00:30:28 +0200 [thread overview]
Message-ID: <20100817223026.GB5461@nowhere> (raw)
In-Reply-To: <201008171125.25956.mitov@issp.bas.bg>
On Tue, Aug 17, 2010 at 11:25:25AM +0300, Marin Mitov wrote:
> Hi all,
>
> The function: reiserfs_evict_inode() ends with:
>
> <snip>
> out:
> end_writeback(inode); /* note this must go after the journal_end to prevent deadlock */
> dquot_drop(inode);
> inode->i_blocks = 0;
> reiserfs_write_unlock_once(inode->i_sb, depth);
>
> no_delete:
> end_writeback(inode);
> dquot_drop(inode);
> }
> <snip>
>
> When goto out path is taken,
>
> end_writeback(inode);
> dquot_drop(inode);
>
> are executed twice, leading to page fault (in my case) during the kernel boot.
>
> Add return; before no_delete label (but I am not quite sure that this is correct :-).
>
> Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
In fact the sam patch has been submitted and applied to the vfs tree already:
http://lkml.org/lkml/2010/8/11/98
The patch will probably reach mainline soon.
Thanks.
prev parent reply other threads:[~2010-08-17 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 8:25 [BUG][reiserfs] page fault during kernel boot Marin Mitov
2010-08-17 22:20 ` Frederic Weisbecker
2010-08-17 22:30 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817223026.GB5461@nowhere \
--to=fweisbec@gmail.com \
--cc=b3nton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitov@issp.bas.bg \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox