From: Frederic Weisbecker <fweisbec@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Stephane Eranian <eranian@google.com>,
David Miller <davem@davemloft.net>,
Paul Mundt <lethal@linux-sh.org>,
Will Deacon <will.deacon@arm.com>, Borislav Petkov <bp@amd64.org>
Subject: Re: [RFC PATCH 3/6] perf: Generalize some arch callchain code
Date: Wed, 18 Aug 2010 05:51:11 +0200 [thread overview]
Message-ID: <20100818035109.GC24748@nowhere> (raw)
In-Reply-To: <20100817034634.GB24726@drongo>
On Tue, Aug 17, 2010 at 01:46:34PM +1000, Paul Mackerras wrote:
> On Mon, Aug 16, 2010 at 10:48:32PM +0200, Frederic Weisbecker wrote:
>
> > - Most archs use one callchain buffer per cpu, except x86 that needs
> > to deal with NMIs. Provide a default perf_callchain_buffer()
> > implementation that x86 overrides.
> >
> > - Centralize all the kernel/user regs handling and invoke new arch
> > handlers from there: perf_callchain_user() / perf_callchain_kernel()
> > That avoid all the user_mode(), current->mm checks and so...
> >
> > - Invert some parameters in perf_callchain_*() helpers: entry to the
> > left, regs to the right, following the traditional (src, dst).
>
> I think you mean (dst, src), don't you?
Indeed yeah :)
> Apart from that, the patch looks OK, so
>
> Acked-by: Paul Mackerras <paulus@samba.org>
Thanks a lot for your reviews and acks!
next prev parent reply other threads:[~2010-08-18 3:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 20:48 [RFC PATCH 0/0 v3] callchain fixes and cleanups Frederic Weisbecker
2010-08-16 20:48 ` [RFC PATCH 1/6] perf: Drop unappropriate tests on arch callchains Frederic Weisbecker
2010-08-16 20:48 ` [RFC PATCH 2/6] perf: Generalize callchain_store() Frederic Weisbecker
2010-08-17 4:37 ` Paul Mackerras
2010-08-16 20:48 ` [RFC PATCH 3/6] perf: Generalize some arch callchain code Frederic Weisbecker
2010-08-17 3:46 ` Paul Mackerras
2010-08-18 3:51 ` Frederic Weisbecker [this message]
2010-08-16 20:48 ` [RFC PATCH 4/6] perf: Factorize callchain context handling Frederic Weisbecker
2010-08-17 4:37 ` Paul Mackerras
2010-08-16 20:48 ` [RFC PATCH 5/6] perf: Fix race in callchains Frederic Weisbecker
2010-08-17 1:34 ` [RFC PATCH 5/6 v4] " Frederic Weisbecker
2010-08-17 4:53 ` Paul Mackerras
2010-08-18 3:49 ` Frederic Weisbecker
2010-08-16 20:48 ` [RFC PATCH 6/6] perf: Humanize the number of contexts Frederic Weisbecker
2010-08-17 4:58 ` [RFC PATCH 0/0 v3] callchain fixes and cleanups Borislav Petkov
2010-08-18 3:53 ` Frederic Weisbecker
2010-08-17 10:32 ` Will Deacon
2010-08-18 3:55 ` Frederic Weisbecker
2010-08-18 9:08 ` Will Deacon
2010-08-18 16:15 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2010-07-01 15:35 [RFC PATCH 0/6] perf: cleanup and fixes Frederic Weisbecker
2010-07-01 15:35 ` [RFC PATCH 3/6] perf: Generalize some arch callchain code Frederic Weisbecker
2010-07-01 15:46 ` Peter Zijlstra
2010-07-01 15:47 ` Frederic Weisbecker
2010-07-01 15:49 ` Frederic Weisbecker
2010-07-01 15:51 ` Peter Zijlstra
2010-07-01 15:53 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818035109.GC24748@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=bp@amd64.org \
--cc=davem@davemloft.net \
--cc=eranian@google.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox