Re: [PATCH] [RFCv2] notify userspace about time changes

Andrew Morton
2010-08-19T04:38:06Z

On Wed, 18 Aug 2010 21:09:37 -0700 Greg KH <gregkh@suse.de> wrote:

> On Wed, Aug 18, 2010 at 04:53:03PM -0700, Andrew Morton wrote:
> > Is sysfs the right interface for this thing? Bear in mind that
> > CONFIG_SYSFS does exist.
> >
> > > + fd = open("/sys/kernel/time_notify", O_WRONLY);
> > > + fdprintf(fd, "%d 1 0 1 1", efd);
> >
> > why not
> >
> > sys_time_notify(efd, 1, 0, 1, 1);
>
> Yeah, that would be much better than a sysfs file, this is abusing the
> sysfs interface quite a lot.
>

(time_change_notify would be a better syscall name).