Re: [PATCH] [RFCv2] notify userspace about time changes

Kay Sievers
2010-08-19T08:39:59Z

On Thu, Aug 19, 2010 at 10:36, Kirill A. Shutemov <kirill@shutemov.name> wrote:
> On Wed, Aug 18, 2010 at 09:09:37PM -0700, Greg KH wrote:
>> On Wed, Aug 18, 2010 at 04:53:03PM -0700, Andrew Morton wrote:
>> > Is sysfs the right interface for this thing?  Bear in mind that
>> > CONFIG_SYSFS does exist.
>> >
>> > > +              fd = open("/sys/kernel/time_notify", O_WRONLY);
>> > > +              fdprintf(fd, "%d 1 0 1 1", efd);
>> >
>> > why not
>> >
>> >             sys_time_notify(efd, 1, 0, 1, 1);
>>
>> Yeah, that would be much better than a sysfs file, this is abusing the
>> sysfs interface quite a lot.
>
> Do you really think, that increasing number of syscalls is better then
> fs-based interfaces?

Not necessarily, but adding such, and from the outside scope 'random
stuff', to /sys/kernel/ is really not the way to do such things.

It seems to be new dumping ground for things that don't have an
obvious home, and since proc is out of fashion. :)

Can't timerfd be used, or extended in some way? It really sounds like
the place this should happen.

Kay