Re: [PATCH] [RFCv2] notify userspace about time changes

Alexander Shishkin
2010-08-19T08:30:27Z

On Wed, Aug 18, 2010 at 09:09:37 -0700, Greg KH wrote:
> On Wed, Aug 18, 2010 at 04:53:03PM -0700, Andrew Morton wrote:
> > Is sysfs the right interface for this thing? Bear in mind that
> > CONFIG_SYSFS does exist.
> >
> > > + fd = open("/sys/kernel/time_notify", O_WRONLY);
> > > + fdprintf(fd, "%d 1 0 1 1", efd);
> >
> > why not
> >
> > sys_time_notify(efd, 1, 0, 1, 1);
>
> Yeah, that would be much better than a sysfs file, this is abusing the
> sysfs interface quite a lot.

Hm, ok. I used to think that adding new syscalls was discouraged, though.

Regards,
--
Alex